Allow customization of DataNucleus via pass-through properties #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is mostly meant to address stevespringett#493, but may be useful for other use cases as well. Due to the sheer amount of configuration options in DataNucleus (and potentially other frameworks), it is not practical to add `AlpineKey`s for all of them. With this change, it is possible to disable the DataNucleus L2 cache by either: * Setting the property `alpine.datanucleus.cache.level2.type=none` in `application.properties`, or * Setting the environment variable `ALPINE_DATANUCLEUS_CACHE_LEVEL2_TYPE=none` Signed-off-by: nscuro <[email protected]>
|
Is this ready to merge? |
|
@stevespringett Yes, ready to go! |
nscuro
added a commit
to nscuro/dependency-track
that referenced
this pull request
Jun 12, 2023
Includes stevespringett/Alpine#494 among other changes so far. Also added documentation for `alpine.datanucleus.cache.level2.type`. Signed-off-by: nscuro <[email protected]>
1 task
melba-lopez
pushed a commit
to melba-lopez/dependency-track
that referenced
this pull request
Jun 23, 2023
Includes stevespringett/Alpine#494 among other changes so far. Also added documentation for `alpine.datanucleus.cache.level2.type`. Signed-off-by: nscuro <[email protected]> Signed-off-by: Melba Lopez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mostly meant to address #493, but may be useful for other use cases as well.
Due to the sheer amount of configuration options in DataNucleus (and potentially other frameworks), it is not practical to add
AlpineKeys for all of them.With this change, it is possible to disable the DataNucleus L2 cache by either:
alpine.datanucleus.cache.level2.type=noneinapplication.properties, orALPINE_DATANUCLEUS_CACHE_LEVEL2_TYPE=noneCloses #493