Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update new components #60

Merged
merged 4 commits into from
Aug 7, 2018
Merged

Conversation

gavinorland
Copy link
Collaborator

Since the last PR was merged and master was bumped, the cleanest thing to do here has been to create a new branch from master for these remaining edits. Other issues I have logged. If this one is approved and merged I'll delete the other branch (and this one)! Thanks.

These commits add default props to ArrayObjectTable and ObjectTable.

@gavinorland gavinorland requested a review from stevesims August 7, 2018 15:06
@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          22     22           
  Lines         199    201    +2     
  Branches       40     39    -1     
=====================================
+ Hits          199    201    +2
Impacted Files Coverage Δ
components/object-table/src/index.js 100% <100%> (ø) ⬆️
components/array-object-table/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d75185d...0d2e9e1. Read the comment docs.

stevesims
stevesims previously approved these changes Aug 7, 2018
@gavinorland gavinorland merged commit 97bdef2 into master Aug 7, 2018
@gavinorland gavinorland deleted the feature/update-new-components branch August 7, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants