-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config documentation clarification #100
Comments
I think the current information is correct
(I maybe a bit biased as I wrote it 😄 ) Which is kinda what you are saying "The distinction between US and UK language is based on the Echo being used, I think." Maybe you didn't spot it in the notes section? |
I think the current information is correct
This Skill was developed to only work on English (US) language devices.
(I maybe a bit biased as I wrote it 😄 )
I’m sure you are correct. The bit I’m referring to really is a bit later under “Interaction model”. Perhaps instead of "US English Users" you might consider “Echo set to use US English”. Actually, I really like your documentation and it’s really quite easy to get it running.
Which is kinda what you are saying "The distinction between US and UK language is based on the Echo being used, I think."
Maybe you didn't spot it in the notes section?
I think I skimmed over that part. As the note is currently only important for the interaction model you might consider moving it there.
Anyway, great work and thanks for sharing.
|
Thanks, but I can't the credit. All I did was update the docs and cobbled together the UK workaround. I will add the clarification, but steven will have to merge it |
see stevenleeg#100 for more
Just merged it in. Is there anything else that needs to get done here or is this issue good to close? |
It looks good to me 😊 |
Over two months after merge, close this issue? |
Apologies if you were waiting on input from me. Yes.
On Tue, 22 Aug 2017, 08:22 Adam Jones ***@***.***> wrote:
Over two months after merge, close this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB_junkSEwTu_-bIsYyw0vjKNhIwtFMmks5sah9MgaJpZM4N2Hk6>
.
--
Please excuse any typos or auto-correct-ups which I will make, I am sorry
for any offence that they will cause, they will have been typed on phone
using a virtual keyboard with autocorrect.
|
The distinction between US and UK language is based on the Echo being used, I think. I have a UK google music account but a US Dot using US english (and I'm in Brunei.) This, basis for following different instructions (the language of the Echo) isn't very clear from the docs.
I followed instruction for the US configuration (with Heroku) which I expected to fail (because I have a UK google music account) but were so much simpler I thought it was worth a try. Slightly surprised to find it worked 😊
The text was updated successfully, but these errors were encountered: