Support building a pip package using scikit-build #559
Conversation
|
Hmm, it looks like https://github.com/DanielBok/nlopt-python does the same thing. |
|
Perhaps we should remove the python parts from the existing nlopt conda package and just onboard nlopt-python as a separate conda package? Not sure the best path since technically both of these libraries produce python bindings |
|
|
@stevengj @DanielBok @jschueller, any thoughts on how to proceed? |
| ) | ||
| configure_file( | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/nlopt.i | ||
| ${CMAKE_CURRENT_BINARY_DIR}/python/nlopt.i |
There was a problem hiding this comment.
Is there a good reason why these have to be copied? Why can't they be used directly from the source dir?
| set (NLopt_ROOT @CMAKE_CURRENT_BINARY_DIR@/../../) | ||
| find_package (NLopt CONFIG REQUIRED) | ||
|
|
||
| set (SWIG_MODULE__nlopt_EXTRA_DEPS nlopt-python.i numpy.i) |
There was a problem hiding this comment.
Couldn't this depend on ../nlopt-python.i etcetera if the paths are set correctly?
There was a problem hiding this comment.
I spent quite some time trying to set up paths correctly, but couldn't figure out how to do it.
Helps make the conda package have correct pip metadata.
Makes it possible to create wheels and have them uploaded to PyPI later.