-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add japanese translation #1530
Add japanese translation #1530
Conversation
f957385
to
15888e7
Compare
15888e7
to
45ca2fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thank you very, very much for doing this!
When introducing a new language, such as Japanese, it must be created as a Resources.ja-JP.resx, and then only use a hints file to override the necessary customizations. Starting with only a hints file breaks the workflow used to build OneMore.
Whenever new translatable resources are added to OneMore, the ResxTranslator utility is used to read from and sync with the en-US.resx file to updated all other language .resx files in a controlled manner. The hints files are static overrides so would never get updated when new strings are added, updated, or removed to OneMore. That means ja-JP-hints would almost immediately be out of date and broken on the next release.
Please convert this to a ja-JP.resx file and only create a hints file if necessary. I cannot accept this commit until then.
@forestail, I can add a base ja-JP file and then put it out for review to create hints where necessary. I'm happy to do that using ResxTranslator since it will automate the whole process quickly. Yes, it uses Google translator and won't be 100% accurate, but it's a better starting place that fits the model. |
@stevenmcohn Thank you for your comment. Following your advice, I have created the "Resources.ja-JP.resx" file. I have tested OneMore with this file in my environment, and it is working correctly. |
@forestail Thanks! It is behind, missing a couple of string. But that's OK. I'll patch it up with ResxTranslator. I did a random check of about 15 strings and they look good. I'm sure some hints will be needed. But this is a great start. Thank you for helping out. |
* Add Japanese translations * Add Resources.ja-JP.resx
* Add Japanese translations * Add Resources.ja-JP.resx
IS YOUR COMMIT SIGNED?
Yes.
Enhancement or Defect Addressed by This PR
This PR adds Japanese translations. The file 'Resources.ja-JP-hints.xml' was created to ensure the expressions are natural for native Japanese speakers.
This will undoubtedly serve as a motivation for millions of OneNote users in Japan to adopt OneMore.
Description of Proposed Changes
Please use "ResxTranslator" to reference "Resources.ja-JP-hints.xml" and generate "Resources.ja-JP.resx".