Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Heading Styles Don't Honor Font Size 11 #1738

Closed
dwillis77 opened this issue Dec 29, 2024 · 3 comments · Fixed by #1742
Closed

Custom Heading Styles Don't Honor Font Size 11 #1738

dwillis77 opened this issue Dec 29, 2024 · 3 comments · Fixed by #1742
Assignees
Labels
bug Something isn't working released Available in a released installer styles Related to OneMore My Styles

Comments

@dwillis77
Copy link

Problem to Solve

Strange issue - it seems that if we create a custom style, of type "heading" with a font size 11, it will ignore the font size. We can set other attributes, such as bold and italic and those are honored but the font size is not.

The strange part is what it does use as the font size instead - I haven't quite figured that out yet. In one test it used font size 14, in another it did 12. The best I can tell, it seems like it might be using the font size of the heading "in front" of it (meaning the heading one spot higher in the list), because the test I did that resulted in font size 12 had a heading above it with font size 12, and the one that resulted in font size 14 had a heading above it w/ font size 14. That part is a total guess though.

To Reproduce

Steps to reproduce the behavior:

  1. Create a custom style, either from some existing text or from scratch. Make sure to set type as "Heading - include in TOC". Reorder as necessary to put it at the top of the list or wherever you want it in relation to the other heading styles. Configure the other attributes of the heading the way you want, but make sure font size is set to 11.
  2. Apply the new custom style to some text.
  3. See that all the attributes are properly applied except the font size - font size will be something other than 11 (as noted above, I haven't figured out exactly where it gets the size that it does use from, but my hypothesis is above).

Expected Behavior

The style should apply all configured attributes to the selected text, including font size.

Environment (if applicable)

  • OneNote Version: Office 365 version 2402 (build 17328.20648) semi-annual channel, 64-bit
  • OneMore Version 6.6.1
@dwillis77 dwillis77 added bug Something isn't working unread I have seen it or had time to refine it yet labels Dec 29, 2024
@stevencohn
Copy link
Owner

I could no reproduce this, trying a bunch of ways.
I've created a style as shown here, ordered just after Heading 6

image

And then tried to make it break:

1738-demo

@stevencohn stevencohn added no-repro Cannot reproduce and removed unread I have seen it or had time to refine it yet labels Dec 29, 2024
@dwillis77
Copy link
Author

dwillis77 commented Dec 30, 2024

In your screenshot it shows font size 16 though - from what I've seen this only applies to heading styles with font size 11. Any other font size is honored properly (at least, the other sizes I tested - 12, 14 and 16 - all worked fine). Only font size 11 is not. In other words if you create a heading style with font size 11, and apply it to some text the text size will get changed to something other than 11 (even if the underlying text was size 11 to begin with).

@stevencohn
Copy link
Owner

Ah yes, it seems to be whatever your default font size is. My default font size is 11.5 (because I'm wicked old!) So if I set the size of the heading to 11.5, it gets rendered as 20. I'll check it out. Thanks.

@stevencohn stevencohn added styles Related to OneMore My Styles and removed no-repro Cannot reproduce labels Dec 30, 2024
stevencohn added a commit that referenced this issue Dec 30, 2024
stevencohn added a commit that referenced this issue Dec 30, 2024
@stevencohn stevencohn self-assigned this Dec 30, 2024
@stevencohn stevencohn added the next-release Addressed but not yet released label Dec 30, 2024
@stevencohn stevencohn linked a pull request Dec 30, 2024 that will close this issue
@stevencohn stevencohn modified the milestone: 6.2.1 Dec 31, 2024
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in a released installer styles Related to OneMore My Styles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants