Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbering page with alpha-numeric creates accented small i in Turkish "ı" therefore cannot remove numbering. #1437

Closed
bekirkatranci opened this issue Jun 19, 2024 · 1 comment · Fixed by #1464
Closed

Numbering page with alpha-numeric creates accented small i in Turkish "ı" therefore cannot remove numbering. #1437

bekirkatranci opened this issue Jun 19, 2024 · 1 comment · Fixed by #1464
Assignees
@stevencohn
Labels
bug Something isn't working released Available in a released installer

Comments

@bekirkatranci
Copy link

Numbering page with alpha-numeric creates accented small i in Turkish "ı" therefore cannot remove numbering.

Activate Turkish locale in Windows and create numbering then remove numbering. Roman numeral level remains but other levels are cleared.

image

image

Probably because of this implementation, might need to enforce localization.

image

Remove numbering regex doesn't include Turkish "ı":

image
@bekirkatranci bekirkatranci added bug Something isn't working unread I have seen it or had time to refine it yet labels Jun 19, 2024
@bekirkatranci
Copy link
Author

bekirkatranci commented Jun 20, 2024 •
edited
Loading

Instead of using .ToLower(), .ToLowerInvariant() solves the issue. Tested for a different console code snippet locally.

@stevencohn stevencohn removed the unread I have seen it or had time to refine it yet label Jun 20, 2024
@stevencohn stevencohn self-assigned this Jul 10, 2024
stevencohn added a commit that referenced this issue Jul 10, 2024
@stevencohn
ToLowerInvariant to force proper char set of roman numbering
35cc0cd 
#1437
@stevencohn stevencohn mentioned this issue Jul 10, 2024
Merged
stevencohn added a commit that referenced this issue Jul 10, 2024
@stevencohn
ToLowerInvariant to force proper char set of roman numbering (#1464)
bc1d090 
#1437
@stevencohn stevencohn linked a pull request Jul 10, 2024 that will close this issue
ToLowerInvariant to force proper char set of roman numbering #1464
Merged
@stevencohn stevencohn added the next-release Addressed but not yet released label Jul 10, 2024
weissm pushed a commit to weissm/OneMore that referenced this issue Jul 15, 2024
@stevencohn @weissm
ToLowerInvariant to force proper char set of roman numbering (stevenc…
2dc1b65 
…ohn#1464)

stevencohn#1437
weissm pushed a commit to weissm/OneMore that referenced this issue Jul 15, 2024
@stevencohn @weissm
ToLowerInvariant to force proper char set of roman numbering (stevenc…
6326000 
…ohn#1464)

stevencohn#1437
@stevencohn stevencohn added released Available in a released installer and removed next-release Addressed but not yet released labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevencohn stevencohn

Labels
bug Something isn't working released Available in a released installer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ToLowerInvariant to force proper char set of roman numbering stevencohn/OneMore
2 participants
@stevencohn @bekirkatranci