Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow graceful termination of TCPConnection. #66

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Allow graceful termination of TCPConnection. #66

merged 1 commit into from
Oct 17, 2017

Conversation

binarybana
Copy link
Contributor

Fixes #65

According to rust docs, read on a socket returning 0 bytes is a valid way to indicate the connection has been closed.

@binarybana binarybana mentioned this pull request Oct 17, 2017
Closed
@binarybana
Copy link
Contributor Author

Though now that I'm looking at this more closely, won't this read method silently truncate when the request is larger than 512 bytes?

@steveklabnik
Copy link
Owner

won't this read method silently truncate when the request is larger than 512 bytes?

Yes, that's #19

steveklabnik
steveklabnik approved these changes Oct 17, 2017
View reviewed changes
Copy link
Owner

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton, this is 👍

@steveklabnik steveklabnik merged commit 66d8b4d into steveklabnik:master Oct 17, 2017
@ashleygwilliams ashleygwilliams added this to the 0.2.0 milestone Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

panics when benchmarking with wrk
3 participants
@binarybana @steveklabnik @ashleygwilliams