Update HttpDriver.php

[adrianopedro]

The throw() method on $this->http()->throw() on method process throws is not valid as it is not a method of http anymore. Using laravel 8.12 it works by simply removing the throw() call.

[jeanlucnguyen]

The "->connectTimeout(3)" method in
return value($callback, Http::timeout(3)->connectTimeout(3));

does not exist yet in Laravel 8 as well
https://github.com/laravel/framework/blob/8.x/src/Illuminate/Support/Facades/Http.php

[stevebauman]

Thanks guys -- apologies on the wait for this. This PR won't work as intended, as false won't properly be returned if the request fails (5XX/4XX status code). I'll patch this and close this PR once complete.

[stevebauman]

@jeanlucnguyen The connectTimeout method isn't used in this library. A config array is used instead:

location/src/Drivers/HttpDriver.php

Lines 50 to 57 in b604125

	$callback = static::$httpResolver ?: fn ($http) => $http;
	return value($callback, Http::withOptions(
	config('location.http', [
	'timeout' => 3,
	'connect_timeout' => 3,
	])
	));

Where did you find that?

[stevebauman]

I've created a new release resolving this (v7.4.1), thanks again for the report!

[jeanlucnguyen]

@stevebauman Thanks for the quick release !

Right, about connectTimeout, I was doing my tests on v7.2 but just noticed you already removed it on the upgrade from v7.2.2 and v7.3.0

[stevebauman]

@jeanlucnguyen ahh ok understood!

Happy to help! 🙏