Fixes incorrect property access on MaxMind driver when passing off in… #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formation from the Fluent object to the Position object
|
Awesome thanks @craigpaul! Appreciate the PR 🙏 I've just released v7.1.4 with this patch. |
greyaxie
reviewed
Mar 11, 2024
| @@ -92,7 +92,7 @@ protected function hydrate(Position $position, Fluent $location): Position | |||
| $position->cityName = $location->city; | |||
| $position->postalCode = $location->postal; | |||
| $position->metroCode = $location->metro_code; | |||
| $position->timezone = $location->time_zone; | |||
| $position->timezone = $location->timezone; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request fixes #160, where the timezone field in the MaxMind driver gets nullified during the processing of the IP due to an underscore mismatch in property naming.
Changes Made:
Updated the MaxMind driver to access the correct timezone field, aligning it with the naming convention used in the Fluent class.
Updated corresponding tests to ensure the proper functioning of the updated driver.