Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: mevboost-EL & CL in molecule test #667

Merged
merged 41 commits into from
Sep 7, 2022
Merged

ADD: mevboost-EL & CL in molecule test #667

merged 41 commits into from
Sep 7, 2022

Conversation

gbayasgalan
Copy link
Contributor

@gbayasgalan gbayasgalan commented Aug 17, 2022

part of: #529
#692

Consensus:

  • Lighthouse
  • Nimbus
  • Prysm
  • Teku

Execution:

  • Besu
  • Geth
  • Nethermind

@gbayasgalan gbayasgalan requested a review from stefa2k August 17, 2022 10:39
@gbayasgalan gbayasgalan changed the title ADD: mevboost-besu-lighthouse in molecule test ADD: mevboost-EL & CL in molecule test Aug 22, 2022
@gbayasgalan gbayasgalan marked this pull request as ready for review August 23, 2022 20:19
Copy link
Member

@stefa2k stefa2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these changes:

  • remove location of create.yaml of block Create molecule instance(s), there is no need for this anymore
  • trim down the parameters of the el/cl as much as possible to make it clear what parameters matter to run with mev-boost
  • use a variable of stereum_defaults.yaml for https://0xafa4c6985aa049fb79dd37010438cfebeb0f2bd42b115b89dd678dab0670c1de38da0c4e9138c9290a398ecd9a0b3110@builder-relay-goerli.flashbots.net

Is there any log output on the consensus or execution client that would verify the connection to mev-boost?

command: "docker logs stereum-5bc8cb90-1909-11ed-9142-cf15cf490a91"
register: lighthouse_beacon
until:
- lighthouse_beacon.stderr is search("The execution endpoint is connected and configured, however it is not yet synced")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lighthouse doesn't show any information about a connection between mevboost and beacon node

@gbayasgalan gbayasgalan requested a review from stefa2k August 27, 2022 14:04
@gbayasgalan gbayasgalan requested a review from NeoPlays September 6, 2022 00:24
@stefa2k stefa2k merged commit 468004f into stereum-dev:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants