Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: replace stereum/* docker images in molecule tests & EDIT: CLI import is deactivated #306

Merged
merged 5 commits into from
May 23, 2022

Conversation

gbayasgalan
Copy link
Contributor

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@gbayasgalan gbayasgalan requested review from stefa2k and NeoPlays May 20, 2022 23:07
Copy link
Member

@stefa2k stefa2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about deactivating CLI validator-import tests? See comment. Would safe us some time right?

-v "/opt/app/services/{{ validator_service_name }}/validator":"/opt/app/validator" \
-v "/opt/app/services/{{ validator_service_name }}/launchpad":"/opt/app/launchpad" \
-v $HOME/.lighthouse:/root/.lighthouse \
-v "/opt/app/services/2e83d610-48b8-11ec-802a-330dee8e6b2e/validator":"/opt/app/validator" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fixed path, it will break as soon as this actually get's used. However, I don't think we need those CLI imports anymore.

What do you think about deactivating all tests regarding CLI import? It looks like import via API works anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI import is deactivated

@gbayasgalan gbayasgalan requested a review from stefa2k May 23, 2022 08:31
@gbayasgalan gbayasgalan changed the title FIX: replace stereum/* docker images in molecule tests FIX: replace stereum/* docker images in molecule tests & EDIT: CLI import is deactivated May 23, 2022
@stefa2k stefa2k merged commit 4208746 into stereum-dev:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants