Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable loading models with <freejoint/> attribute #5

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Enable loading models with <freejoint/> attribute #5

merged 5 commits into from
Apr 17, 2024

Conversation

chernyadev
Copy link
Collaborator

  • Enable loading models with attribute
  • Fix np.ndarray -> float warning
  • Fix setting bodies and geoms non-kinematics

stepjam
stepjam approved these changes Apr 17, 2024
View reviewed changes
Copy link
Owner

@stepjam stepjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stepjam stepjam merged commit 085fba4 into dev Apr 17, 2024
2 checks passed
@chernyadev chernyadev deleted the feature/freejoint_attach branch April 18, 2024 08:19
stepjam pushed a commit that referenced this pull request Jul 29, 2024
@chernyadev @stepjam
Enable loading models with <freejoint/> attribute (#5)
9cdde12 
* Fix set_kinematic(False)

* Fix warning

* Can load models with freejoints

* Refactor

* Refactor

---------

Co-authored-by: Nikita Chernyadev <[email protected]>
stepjam added a commit that referenced this pull request Jul 29, 2024
@stepjam @chernyadev
Merge Dev (#8)
ba9c390 
* Bring all transfroms to base class

* Kinematic moved to base

* refactor

* Enable loading models with <freejoint/> attribute (#5)

* Fix set_kinematic(False)

* Fix warning

* Can load models with freejoints

* Refactor

* Refactor

---------

Co-authored-by: Nikita Chernyadev <[email protected]>

* Reset velocity and acceleration on position/rotation set (#6)

Co-authored-by: Nikita Chernyadev <[email protected]>

* Add optional collision check warning

---------

Co-authored-by: Nikita Chernyadev <[email protected]>
Co-authored-by: Nikita Chernyadev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepjam stepjam stepjam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chernyadev @stepjam