wip

src/Common/src/System/Net/NetworkInformation/NetworkInformationException.cs

@@ -13,6 +13,7 @@ namespace System.Net.NetworkInformation
     ///       Provides NetworkInformation exceptions to the application.
     ///    </para>
     /// </devdoc>
+    [Serializable]
     public class NetworkInformationException : Win32Exception
     {
         /// <devdoc>
@@ -41,6 +42,10 @@ internal NetworkInformationException(string message) : base(message)
         {
         }
 
+        protected NetworkInformationException(SerializationInfo serializationInfo, StreamingContext streamingContext) : base(serializationInfo, streamingContext)
+        {
+        }
+
         /// <devdoc>
         ///    <para>[To be supplied.]</para>
         /// </devdoc>

src/Microsoft.CSharp/ref/Microsoft.CSharp.cs

@@ -56,16 +56,20 @@ public enum CSharpBinderFlags
         ResultIndexed = 64,
         ValueFromCompoundAssignment = 128,
     }
+    [System.Serializable]
     public partial class RuntimeBinderException : System.Exception
     {
         public RuntimeBinderException() { }
         public RuntimeBinderException(string message) { }
         public RuntimeBinderException(string message, System.Exception innerException) { }
+        protected RuntimeBinderException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) : base(info, context) { }
     }
+    [System.Serializable]
     public partial class RuntimeBinderInternalCompilerException : System.Exception
     {
         public RuntimeBinderInternalCompilerException() { }
         public RuntimeBinderInternalCompilerException(string message) { }
         public RuntimeBinderInternalCompilerException(string message, System.Exception innerException) { }
+        protected RuntimeBinderInternalCompilerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) : base(info, context) { }
     }
 }

src/Microsoft.CSharp/ref/project.json

@@ -1,13 +1,13 @@
 {
   "dependencies": {
-    "System.Runtime": "4.0.0",
+    "System.Runtime": "4.2.0-beta-devapi-24424-01",
     "System.Dynamic.Runtime": "4.0.0",
     "System.Linq.Expressions": "4.0.0"
   },
   "frameworks": {
-    "netstandard1.0": {
+    "netstandard1.7": {
       "imports": [
-        "dotnet5.1"
+        "dotnet5.8"
       ]
     }
   }

src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/RuntimeBinderException.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Runtime.Serialization;
 
 namespace Microsoft.CSharp.RuntimeBinder
 {
@@ -11,6 +12,7 @@ namespace Microsoft.CSharp.RuntimeBinder
     /// <see cref="RuntimeBinderException"/> represents a failure to bind in the sense of a usual compiler error, whereas <see cref="RuntimeBinderInternalCompilerException"/>
     /// represents a malfunctioning of the runtime binder itself.
     /// </summary>
+    [Serializable]
     public class RuntimeBinderException : Exception
     {
         /// <summary>
@@ -40,5 +42,9 @@ public RuntimeBinderException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
+
+        protected RuntimeBinderException(SerializationInfo info, StreamingContext context) : base(info, context)
+        {
+        }
     }
 }

src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/RuntimeBinderInternalCompilerException.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Runtime.Serialization;
 
 namespace Microsoft.CSharp.RuntimeBinder
 {
@@ -11,6 +12,7 @@ namespace Microsoft.CSharp.RuntimeBinder
     /// <see cref="RuntimeBinderException"/> represents a failure to bind in the sense of a usual compiler error, whereas <see cref="RuntimeBinderInternalCompilerException"/>
     /// represents a malfunctioning of the runtime binder itself.
     /// </summary>
+    [Serializable]
     public class RuntimeBinderInternalCompilerException : Exception
     {
         /// <summary>
@@ -40,5 +42,9 @@ public RuntimeBinderInternalCompilerException(string message, Exception innerExc
             : base(message, innerException)
         {
         }
+
+        protected RuntimeBinderInternalCompilerException(SerializationInfo info, StreamingContext context) : base(info, context)
+        {
+        }
     }
 }

src/Microsoft.CSharp/src/project.json

@@ -5,7 +5,7 @@
     "System.Diagnostics.Debug": "4.0.10",
     "System.Diagnostics.Tools": "4.0.0",
     "System.Dynamic.Runtime": "4.0.0",
-    "System.Globalization": "4.0.10",
+    "System.Globalization": "4.0.12-beta-devapi-24424-01",
     "System.Linq": "4.0.0",
     "System.Linq.Expressions": "4.0.0",
     "System.ObjectModel": "4.0.10",
@@ -14,16 +14,16 @@
     "System.Reflection.Primitives": "4.0.0",
     "System.Reflection.TypeExtensions": "4.0.0",
     "System.Resources.ResourceManager": "4.0.0",
-    "System.Runtime": "4.0.20",
+    "System.Runtime": "4.2.0-beta-devapi-24424-01",
     "System.Runtime.Extensions": "4.0.10",
     "System.Runtime.InteropServices": "4.0.20",
     "System.Threading": "4.0.10",
     "System.Threading.Tasks": "4.0.10"
   },
   "frameworks": {
-    "netstandard1.3": {
+    "netstandard1.7": {
       "imports": [
-        "dotnet5.4"
+        "dotnet5.8"
       ]
     }
   }

src/Microsoft.CSharp/tests/Microsoft.CSharp.Tests.csproj

@@ -5,12 +5,16 @@
     <ProjectGuid>{82B54697-0251-47A1-8546-FC507D0F3B08}</ProjectGuid>
     <AssemblyName>Microsoft.CSharp.Tests</AssemblyName>
     <RootNamespace>Microsoft.CSharp.Tests</RootNamespace>
-    <NugetTargetMoniker>.NETStandard,Version=v1.3</NugetTargetMoniker>
+    <NugetTargetMoniker>.NETStandard,Version=v1.7</NugetTargetMoniker>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'" />
   <ItemGroup>
     <Compile Include="CSharpArgumentInfoTests.cs" />
+    <Compile Include="BinarySerializationTests.cs" />
+    <Compile Include="$(CommonTestPath)\System\Runtime\Serialization\Formatters\BinaryFormatterHelpers.cs">
+      <Link>Common\System\Runtime\Serialization\Formatters\BinaryFormatterHelpers.cs</Link>
+    </Compile>
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\pkg\Microsoft.CSharp.pkgproj">

src/Microsoft.Win32.Primitives/ref/Microsoft.Win32.Primitives.cs

@@ -8,13 +8,16 @@
 
 namespace System.ComponentModel
 {
+    [Serializable]
     public partial class Win32Exception : System.Exception
     {
         public Win32Exception() { }
         public Win32Exception(int error) { }
         public Win32Exception(int error, string message) { }
         public Win32Exception(string message) { }
         public Win32Exception(string message, System.Exception innerException) { }
+        protected Win32Exception(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) : base(info, context) { }
         public int NativeErrorCode { get { return default(int); } }
+        public override void GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
     }
 }

src/Microsoft.Win32.Primitives/src/System/ComponentModel/Win32Exception.cs

@@ -5,13 +5,15 @@
 using System;
 using System.Text;
 using System.Runtime.InteropServices;
+using System.Runtime.Serialization;
 
 namespace System.ComponentModel
 {
     /// <devdoc>
     ///    <para>The exception that is thrown for a Win32 error code.</para>
     /// </devdoc>
-    public partial class Win32Exception : Exception
+    [Serializable]
+    public partial class Win32Exception : Exception, ISerializable
     {
         /// <devdoc>
         ///    <para>Represents the Win32 error code associated with this exception. This 
@@ -68,6 +70,22 @@ public Win32Exception(string message, Exception innerException) : base(message,
             HResult = E_FAIL;
         }
 
+        protected Win32Exception(SerializationInfo info, StreamingContext context) : base(info, context)
+        {
+            nativeErrorCode = info.GetInt32(nameof(NativeErrorCode));
+        }
+
+        public override void GetObjectData(SerializationInfo info, StreamingContext context)
+        {
+            if (info == null)
+            {
+                throw new ArgumentNullException(nameof(info));
+            }
+
+            info.AddValue(nameof(NativeErrorCode), nativeErrorCode);
+            base.GetObjectData(info, context);
+        }
+
         /// <devdoc>
         ///    <para>Represents the Win32 error code associated with this exception. This 
         ///       field is read-only.</para>

src/Microsoft.Win32.Registry/ref/Microsoft.Win32.Registry.cs

@@ -20,6 +20,7 @@ public static partial class Registry
         public static void SetValue(string keyName, string valueName, object value) { }
         public static void SetValue(string keyName, string valueName, object value, Microsoft.Win32.RegistryValueKind valueKind) { }
     }
+    [System.Serializable]
     public enum RegistryHive
     {
         ClassesRoot = -2147483648,

src/Microsoft.Win32.Registry/src/Microsoft/Win32/RegistryHive.cs

@@ -2,12 +2,15 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
+
 namespace Microsoft.Win32
 {
     /**
      * Registry hive values.  Useful only for GetRemoteBaseKey
      */
 #if REGISTRY_ASSEMBLY
+    [Serializable]
     public
 #else
     internal

src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/UrlAttribute.cs

@@ -6,6 +6,7 @@ namespace System.ComponentModel.DataAnnotations
 {
     [AttributeUsage(AttributeTargets.Property | AttributeTargets.Field | AttributeTargets.Parameter,
         AllowMultiple = false)]
+    [Serializable]
     public sealed class UrlAttribute : DataTypeAttribute
     {
         public UrlAttribute()

src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/ValidationException.cs

@@ -2,11 +2,14 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System.Runtime.Serialization;
+
 namespace System.ComponentModel.DataAnnotations
 {
     /// <summary>
     ///     Exception used for validation using <see cref="ValidationAttribute" />.
     /// </summary>
+    [Serializable]
     public class ValidationException : Exception
     {
         private ValidationResult _validationResult;
@@ -67,6 +70,11 @@ public ValidationException(string message, Exception innerException)
         {
         }
 
+        protected ValidationException(SerializationInfo info, StreamingContext context)
+            : base(info, context)
+        {
+        }
+
         /// <summary>
         ///     Gets the <see>ValidationAttribute</see> instance that triggered this exception.
         /// </summary>

src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/Validator.cs

@@ -654,6 +654,7 @@ private static bool TryValidate(object value, ValidationContext validationContex
         ///     Private helper class to encapsulate a ValidationAttribute with the failed value and the user-visible
         ///     target name against which it was validated.
         /// </summary>
+        [Serializable]
         private class ValidationError
         {
             internal ValidationError(ValidationAttribute validationAttribute, object value,

src/System.ComponentModel.TypeConverter/src/System/ComponentModel/InvalidAsynchronousStateException.cs

@@ -2,11 +2,14 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System.Runtime.Serialization;
+
 namespace System.ComponentModel
 {
     /// <summary>
     ///    <para>The exception that is thrown when a thread that an operation should execute on no longer exists or is not pumping messages</para>
     /// </summary>
+    [Serializable]
     public class InvalidAsynchronousStateException : ArgumentException
     {
         /// <summary>
@@ -33,5 +36,9 @@ public InvalidAsynchronousStateException(string message, Exception innerExceptio
             : base(message, innerException)
         {
         }
+
+        protected InvalidAsynchronousStateException(SerializationInfo info, StreamingContext context) : base(info, context)
+        {
+        }
     }
 }

src/System.ComponentModel.TypeConverter/src/System/InvariantComparer.cs

@@ -7,6 +7,7 @@
 
 namespace System
 {
+    [Serializable]
     internal class InvariantComparer : IComparer
     {
         private readonly CompareInfo _compareInfo;

src/System.Data.Common/src/System/DBNull.cs

@@ -3,19 +3,28 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-
+using System.Runtime.Serialization;
 
 namespace System
 {
-    public sealed class DBNull
+    [Serializable]
+    public sealed class DBNull : ISerializable
     {
         private DBNull()
         {
         }
 
+        private DBNull(SerializationInfo info, StreamingContext context)
+        {
+            throw new NotSupportedException(SR.NotSupported_DBNullSerial);
+        }
 
         public static readonly DBNull Value = new DBNull();
 
+        public void GetObjectData(SerializationInfo info, StreamingContext context)
+        {
+            UnitySerializationHolder.GetUnitySerializationInfo(info, UnitySerializationHolder.NullUnity, null, null);
+        }
 
         public override String ToString()
         {

src/System.Data.Common/src/System/Data/Common/DbConnectionStringCommon.cs

@@ -13,6 +13,7 @@
 
 namespace System.Data.Common
 {
+    [Serializable]
     internal sealed class ReadOnlyCollection<T> : System.Collections.ICollection, ICollection<T>
     {
         private T[] _items;
@@ -89,6 +90,7 @@ public int Count
             get { return _items.Length; }
         }
 
+        [Serializable]
         internal struct Enumerator<K> : IEnumerator<K>, System.Collections.IEnumerator
         { // based on List<T>.Enumerator
             private K[] _items;

src/System.Data.Common/src/System/Data/Common/DbException.cs

@@ -8,8 +8,8 @@
 
 namespace System.Data.Common
 {
-    public abstract class DbException :
-        Exception
+    [Serializable]
+    public abstract class DbException : Exception
     {
         protected DbException() : base()
         {
@@ -22,5 +22,9 @@ protected DbException(System.String message) : base(message)
         protected DbException(System.String message, System.Exception innerException) : base(message, innerException)
         {
         }
+
+        protected DbException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) : base(info, context)
+        {
+        }
     }
 }

src/System.Data.Common/src/System/Data/Common/NameValuePair.cs

@@ -13,10 +13,12 @@
 
 namespace System.Data.Common
 {
+    [Serializable]
     sealed internal class NameValuePair
     {
         readonly private string _name;
         readonly private string _value;
+        [OptionalField(VersionAdded = 2)]
         readonly private int _length;
         private NameValuePair _next;