Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mix.exs to allow scrivener_ecto ~> 3.0 #9

Merged

Conversation

superhawk610
Copy link
Contributor

@superhawk610 superhawk610 commented Sep 10, 2024

Recently, ecto made some breaking changes with 3.12.0 and scrivener_ecto was updated accordingly (see here). The scrivener_ecto package was also bumped up to a new major version 3.0, though it's a backwards-compatible change with respect to scrivener_list (see the diff here). In other words, it is safe for this package to now support scrivener_ecto at ~> 1.0 or ~> 2.0 or ~> 3.0, which is what this PR does.

This change is required to allow using scrivener_ecto ~> 3.0 and scrivener_list in the same project, otherwise a dependency conflict is raised.

@dgigafox
Copy link

👍🏼 We need this too. Hope to be merged soon

@dcaixinha
Copy link

We also need this! Any chance of merging this @stephenmoloney? 🙏

@stephenmoloney
Copy link
Owner

It's quite a few years since I've been active with Elixir but I've read through the PR description.

And it's reasonable to merge this.

You can reference this in your projects without a publish to mix ?

@stephenmoloney stephenmoloney merged commit 33b44ac into stephenmoloney:master Dec 18, 2024
@olehgerus
Copy link

@stephenmoloney, do you have any plans to release it anytime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants