perf: Generating "else if" where applicable (#1141)

In oneof scenarios, this commit proposes generating "else if" statements
where applicable.

The original idea was an attempt to speed up Typescript compilation by
reducing the amount of paths Typescript can analyze. Spoiler alert =>
nothing changes from that point of view.

The compilation of my [proto
file](https://github.com/workadventure/workadventure/blob/develop/messages/protos/messages.proto)
takes between 41 and 44 seconds with and without "else if" statements.

Still, the "else if" conditions should slightly speed up the runtime
execution, by avoiding unnecessary checks to the Javascript runtime.

This PR is directly linked to
#1135
Note: in #1135, @stephenh you
recommend trying to use a switch statement (instead of "else if"). This
would require a really big refactoring and I'm not familiar enough with
the code base to attempt that.
The "else if" implementation was a bit of a low hanging fruit.

I still think the "//ts-nocheck" annotation would be really useful and
is the way to go, since it would simply take "0 seconds" to typecheck
the generated file (you can't beat 0 in terms of performance 😆
)

integration/oneof-unions-snake/google/protobuf/struct.ts

@@ -401,20 +401,15 @@ export const Value: MessageFns<Value> & AnyValueWrapperFns = {
     const obj: any = {};
     if (message.kind?.$case === "null_value") {
       obj.null_value = nullValueToJSON(message.kind.null_value);
-    }
-    if (message.kind?.$case === "number_value") {
+    } else if (message.kind?.$case === "number_value") {
       obj.number_value = message.kind.number_value;
-    }
-    if (message.kind?.$case === "string_value") {
+    } else if (message.kind?.$case === "string_value") {
       obj.string_value = message.kind.string_value;
-    }
-    if (message.kind?.$case === "bool_value") {
+    } else if (message.kind?.$case === "bool_value") {
       obj.bool_value = message.kind.bool_value;
-    }
-    if (message.kind?.$case === "struct_value") {
+    } else if (message.kind?.$case === "struct_value") {
       obj.struct_value = message.kind.struct_value;
-    }
-    if (message.kind?.$case === "list_value") {
+    } else if (message.kind?.$case === "list_value") {
       obj.list_value = message.kind.list_value;
     }
     return obj;
@@ -429,34 +424,29 @@ export const Value: MessageFns<Value> & AnyValueWrapperFns = {
       object.kind?.$case === "null_value" && object.kind?.null_value !== undefined && object.kind?.null_value !== null
     ) {
       message.kind = { $case: "null_value", null_value: object.kind.null_value };
-    }
-    if (
+    } else if (
       object.kind?.$case === "number_value" &&
       object.kind?.number_value !== undefined &&
       object.kind?.number_value !== null
     ) {
       message.kind = { $case: "number_value", number_value: object.kind.number_value };
-    }
-    if (
+    } else if (
       object.kind?.$case === "string_value" &&
       object.kind?.string_value !== undefined &&
       object.kind?.string_value !== null
     ) {
       message.kind = { $case: "string_value", string_value: object.kind.string_value };
-    }
-    if (
+    } else if (
       object.kind?.$case === "bool_value" && object.kind?.bool_value !== undefined && object.kind?.bool_value !== null
     ) {
       message.kind = { $case: "bool_value", bool_value: object.kind.bool_value };
-    }
-    if (
+    } else if (
       object.kind?.$case === "struct_value" &&
       object.kind?.struct_value !== undefined &&
       object.kind?.struct_value !== null
     ) {
       message.kind = { $case: "struct_value", struct_value: object.kind.struct_value };
-    }
-    if (
+    } else if (
       object.kind?.$case === "list_value" && object.kind?.list_value !== undefined && object.kind?.list_value !== null
     ) {
       message.kind = { $case: "list_value", list_value: object.kind.list_value };

integration/oneof-unions-value/google/protobuf/struct.ts

@@ -398,20 +398,15 @@ export const Value: MessageFns<Value> & AnyValueWrapperFns = {
     const obj: any = {};
     if (message.kind?.$case === "nullValue") {
       obj.nullValue = nullValueToJSON(message.kind.value);
-    }
-    if (message.kind?.$case === "numberValue") {
+    } else if (message.kind?.$case === "numberValue") {
       obj.numberValue = message.kind.value;
-    }
-    if (message.kind?.$case === "stringValue") {
+    } else if (message.kind?.$case === "stringValue") {
       obj.stringValue = message.kind.value;
-    }
-    if (message.kind?.$case === "boolValue") {
+    } else if (message.kind?.$case === "boolValue") {
       obj.boolValue = message.kind.value;
-    }
-    if (message.kind?.$case === "structValue") {
+    } else if (message.kind?.$case === "structValue") {
       obj.structValue = message.kind.value;
-    }
-    if (message.kind?.$case === "listValue") {
+    } else if (message.kind?.$case === "listValue") {
       obj.listValue = message.kind.value;
     }
     return obj;
@@ -424,20 +419,21 @@ export const Value: MessageFns<Value> & AnyValueWrapperFns = {
     const message = createBaseValue();
     if (object.kind?.$case === "nullValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
       message.kind = { $case: "nullValue", value: object.kind.value };
-    }
-    if (object.kind?.$case === "numberValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
+    } else if (
+      object.kind?.$case === "numberValue" && object.kind?.value !== undefined && object.kind?.value !== null
+    ) {
       message.kind = { $case: "numberValue", value: object.kind.value };
-    }
-    if (object.kind?.$case === "stringValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
+    } else if (
+      object.kind?.$case === "stringValue" && object.kind?.value !== undefined && object.kind?.value !== null
+    ) {
       message.kind = { $case: "stringValue", value: object.kind.value };
-    }
-    if (object.kind?.$case === "boolValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
+    } else if (object.kind?.$case === "boolValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
       message.kind = { $case: "boolValue", value: object.kind.value };
-    }
-    if (object.kind?.$case === "structValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
+    } else if (
+      object.kind?.$case === "structValue" && object.kind?.value !== undefined && object.kind?.value !== null
+    ) {
       message.kind = { $case: "structValue", value: object.kind.value };
-    }
-    if (object.kind?.$case === "listValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
+    } else if (object.kind?.$case === "listValue" && object.kind?.value !== undefined && object.kind?.value !== null) {
       message.kind = { $case: "listValue", value: object.kind.value };
     }
     return message;

integration/oneof-unions-value/oneof.ts

@@ -302,32 +302,25 @@ export const PleaseChoose: MessageFns<PleaseChoose> = {
     }
     if (message.choice?.$case === "aNumber") {
       obj.aNumber = message.choice.value;
-    }
-    if (message.choice?.$case === "aString") {
+    } else if (message.choice?.$case === "aString") {
       obj.aString = message.choice.value;
-    }
-    if (message.choice?.$case === "aMessage") {
+    } else if (message.choice?.$case === "aMessage") {
       obj.aMessage = PleaseChoose_Submessage.toJSON(message.choice.value);
-    }
-    if (message.choice?.$case === "aBool") {
+    } else if (message.choice?.$case === "aBool") {
       obj.aBool = message.choice.value;
-    }
-    if (message.choice?.$case === "bunchaBytes") {
+    } else if (message.choice?.$case === "bunchaBytes") {
       obj.bunchaBytes = base64FromBytes(message.choice.value);
-    }
-    if (message.choice?.$case === "anEnum") {
+    } else if (message.choice?.$case === "anEnum") {
       obj.anEnum = pleaseChoose_StateEnumToJSON(message.choice.value);
     }
     if (message.age !== 0) {
       obj.age = Math.round(message.age);
     }
     if (message.eitherOr?.$case === "either") {
       obj.either = message.eitherOr.value;
-    }
-    if (message.eitherOr?.$case === "or") {
+    } else if (message.eitherOr?.$case === "or") {
       obj.or = message.eitherOr.value;
-    }
-    if (message.eitherOr?.$case === "thirdOption") {
+    } else if (message.eitherOr?.$case === "thirdOption") {
       obj.thirdOption = message.eitherOr.value;
     }
     if (message.signature.length !== 0) {
@@ -347,32 +340,37 @@ export const PleaseChoose: MessageFns<PleaseChoose> = {
     message.name = object.name ?? "";
     if (object.choice?.$case === "aNumber" && object.choice?.value !== undefined && object.choice?.value !== null) {
       message.choice = { $case: "aNumber", value: object.choice.value };
-    }
-    if (object.choice?.$case === "aString" && object.choice?.value !== undefined && object.choice?.value !== null) {
+    } else if (
+      object.choice?.$case === "aString" && object.choice?.value !== undefined && object.choice?.value !== null
+    ) {
       message.choice = { $case: "aString", value: object.choice.value };
-    }
-    if (object.choice?.$case === "aMessage" && object.choice?.value !== undefined && object.choice?.value !== null) {
+    } else if (
+      object.choice?.$case === "aMessage" && object.choice?.value !== undefined && object.choice?.value !== null
+    ) {
       message.choice = { $case: "aMessage", value: PleaseChoose_Submessage.fromPartial(object.choice.value) };
-    }
-    if (object.choice?.$case === "aBool" && object.choice?.value !== undefined && object.choice?.value !== null) {
+    } else if (
+      object.choice?.$case === "aBool" && object.choice?.value !== undefined && object.choice?.value !== null
+    ) {
       message.choice = { $case: "aBool", value: object.choice.value };
-    }
-    if (object.choice?.$case === "bunchaBytes" && object.choice?.value !== undefined && object.choice?.value !== null) {
+    } else if (
+      object.choice?.$case === "bunchaBytes" && object.choice?.value !== undefined && object.choice?.value !== null
+    ) {
       message.choice = { $case: "bunchaBytes", value: object.choice.value };
-    }
-    if (object.choice?.$case === "anEnum" && object.choice?.value !== undefined && object.choice?.value !== null) {
+    } else if (
+      object.choice?.$case === "anEnum" && object.choice?.value !== undefined && object.choice?.value !== null
+    ) {
       message.choice = { $case: "anEnum", value: object.choice.value };
     }
     message.age = object.age ?? 0;
     if (
       object.eitherOr?.$case === "either" && object.eitherOr?.value !== undefined && object.eitherOr?.value !== null
     ) {
       message.eitherOr = { $case: "either", value: object.eitherOr.value };
-    }
-    if (object.eitherOr?.$case === "or" && object.eitherOr?.value !== undefined && object.eitherOr?.value !== null) {
+    } else if (
+      object.eitherOr?.$case === "or" && object.eitherOr?.value !== undefined && object.eitherOr?.value !== null
+    ) {
       message.eitherOr = { $case: "or", value: object.eitherOr.value };
-    }
-    if (
+    } else if (
       object.eitherOr?.$case === "thirdOption" &&
       object.eitherOr?.value !== undefined &&
       object.eitherOr?.value !== null

integration/oneof-unions/google/protobuf/struct.ts

@@ -398,20 +398,15 @@ export const Value: MessageFns<Value> & AnyValueWrapperFns = {
     const obj: any = {};
     if (message.kind?.$case === "nullValue") {
       obj.nullValue = nullValueToJSON(message.kind.nullValue);
-    }
-    if (message.kind?.$case === "numberValue") {
+    } else if (message.kind?.$case === "numberValue") {
       obj.numberValue = message.kind.numberValue;
-    }
-    if (message.kind?.$case === "stringValue") {
+    } else if (message.kind?.$case === "stringValue") {
       obj.stringValue = message.kind.stringValue;
-    }
-    if (message.kind?.$case === "boolValue") {
+    } else if (message.kind?.$case === "boolValue") {
       obj.boolValue = message.kind.boolValue;
-    }
-    if (message.kind?.$case === "structValue") {
+    } else if (message.kind?.$case === "structValue") {
       obj.structValue = message.kind.structValue;
-    }
-    if (message.kind?.$case === "listValue") {
+    } else if (message.kind?.$case === "listValue") {
       obj.listValue = message.kind.listValue;
     }
     return obj;
@@ -424,32 +419,31 @@ export const Value: MessageFns<Value> & AnyValueWrapperFns = {
     const message = createBaseValue();
     if (object.kind?.$case === "nullValue" && object.kind?.nullValue !== undefined && object.kind?.nullValue !== null) {
       message.kind = { $case: "nullValue", nullValue: object.kind.nullValue };
-    }
-    if (
+    } else if (
       object.kind?.$case === "numberValue" &&
       object.kind?.numberValue !== undefined &&
       object.kind?.numberValue !== null
     ) {
       message.kind = { $case: "numberValue", numberValue: object.kind.numberValue };
-    }
-    if (
+    } else if (
       object.kind?.$case === "stringValue" &&
       object.kind?.stringValue !== undefined &&
       object.kind?.stringValue !== null
     ) {
       message.kind = { $case: "stringValue", stringValue: object.kind.stringValue };
-    }
-    if (object.kind?.$case === "boolValue" && object.kind?.boolValue !== undefined && object.kind?.boolValue !== null) {
+    } else if (
+      object.kind?.$case === "boolValue" && object.kind?.boolValue !== undefined && object.kind?.boolValue !== null
+    ) {
       message.kind = { $case: "boolValue", boolValue: object.kind.boolValue };
-    }
-    if (
+    } else if (
       object.kind?.$case === "structValue" &&
       object.kind?.structValue !== undefined &&
       object.kind?.structValue !== null
     ) {
       message.kind = { $case: "structValue", structValue: object.kind.structValue };
-    }
-    if (object.kind?.$case === "listValue" && object.kind?.listValue !== undefined && object.kind?.listValue !== null) {
+    } else if (
+      object.kind?.$case === "listValue" && object.kind?.listValue !== undefined && object.kind?.listValue !== null
+    ) {
       message.kind = { $case: "listValue", listValue: object.kind.listValue };
     }
     return message;

integration/oneof-unions/oneof.ts

@@ -302,32 +302,25 @@ export const PleaseChoose: MessageFns<PleaseChoose> = {
     }
     if (message.choice?.$case === "aNumber") {
       obj.aNumber = message.choice.aNumber;
-    }
-    if (message.choice?.$case === "aString") {
+    } else if (message.choice?.$case === "aString") {
       obj.aString = message.choice.aString;
-    }
-    if (message.choice?.$case === "aMessage") {
+    } else if (message.choice?.$case === "aMessage") {
       obj.aMessage = PleaseChoose_Submessage.toJSON(message.choice.aMessage);
-    }
-    if (message.choice?.$case === "aBool") {
+    } else if (message.choice?.$case === "aBool") {
       obj.aBool = message.choice.aBool;
-    }
-    if (message.choice?.$case === "bunchaBytes") {
+    } else if (message.choice?.$case === "bunchaBytes") {
       obj.bunchaBytes = base64FromBytes(message.choice.bunchaBytes);
-    }
-    if (message.choice?.$case === "anEnum") {
+    } else if (message.choice?.$case === "anEnum") {
       obj.anEnum = pleaseChoose_StateEnumToJSON(message.choice.anEnum);
     }
     if (message.age !== 0) {
       obj.age = Math.round(message.age);
     }
     if (message.eitherOr?.$case === "either") {
       obj.either = message.eitherOr.either;
-    }
-    if (message.eitherOr?.$case === "or") {
+    } else if (message.eitherOr?.$case === "or") {
       obj.or = message.eitherOr.or;
-    }
-    if (message.eitherOr?.$case === "thirdOption") {
+    } else if (message.eitherOr?.$case === "thirdOption") {
       obj.thirdOption = message.eitherOr.thirdOption;
     }
     if (message.signature.length !== 0) {
@@ -347,38 +340,37 @@ export const PleaseChoose: MessageFns<PleaseChoose> = {
     message.name = object.name ?? "";
     if (object.choice?.$case === "aNumber" && object.choice?.aNumber !== undefined && object.choice?.aNumber !== null) {
       message.choice = { $case: "aNumber", aNumber: object.choice.aNumber };
-    }
-    if (object.choice?.$case === "aString" && object.choice?.aString !== undefined && object.choice?.aString !== null) {
+    } else if (
+      object.choice?.$case === "aString" && object.choice?.aString !== undefined && object.choice?.aString !== null
+    ) {
       message.choice = { $case: "aString", aString: object.choice.aString };
-    }
-    if (
+    } else if (
       object.choice?.$case === "aMessage" && object.choice?.aMessage !== undefined && object.choice?.aMessage !== null
     ) {
       message.choice = { $case: "aMessage", aMessage: PleaseChoose_Submessage.fromPartial(object.choice.aMessage) };
-    }
-    if (object.choice?.$case === "aBool" && object.choice?.aBool !== undefined && object.choice?.aBool !== null) {
+    } else if (
+      object.choice?.$case === "aBool" && object.choice?.aBool !== undefined && object.choice?.aBool !== null
+    ) {
       message.choice = { $case: "aBool", aBool: object.choice.aBool };
-    }
-    if (
+    } else if (
       object.choice?.$case === "bunchaBytes" &&
       object.choice?.bunchaBytes !== undefined &&
       object.choice?.bunchaBytes !== null
     ) {
       message.choice = { $case: "bunchaBytes", bunchaBytes: object.choice.bunchaBytes };
-    }
-    if (object.choice?.$case === "anEnum" && object.choice?.anEnum !== undefined && object.choice?.anEnum !== null) {
+    } else if (
+      object.choice?.$case === "anEnum" && object.choice?.anEnum !== undefined && object.choice?.anEnum !== null
+    ) {
       message.choice = { $case: "anEnum", anEnum: object.choice.anEnum };
     }
     message.age = object.age ?? 0;
     if (
       object.eitherOr?.$case === "either" && object.eitherOr?.either !== undefined && object.eitherOr?.either !== null
     ) {
       message.eitherOr = { $case: "either", either: object.eitherOr.either };
-    }
-    if (object.eitherOr?.$case === "or" && object.eitherOr?.or !== undefined && object.eitherOr?.or !== null) {
+    } else if (object.eitherOr?.$case === "or" && object.eitherOr?.or !== undefined && object.eitherOr?.or !== null) {
       message.eitherOr = { $case: "or", or: object.eitherOr.or };
-    }
-    if (
+    } else if (
       object.eitherOr?.$case === "thirdOption" &&
       object.eitherOr?.thirdOption !== undefined &&
       object.eitherOr?.thirdOption !== null