Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enablePinchOnMobile set to false completely disables pinch to zoom on mobile #914

Closed
adambeer opened this issue Sep 8, 2021 · 6 comments
Assignees
Labels
bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. Solved

Comments

@adambeer
Copy link

adambeer commented Sep 8, 2021

The description of enablePinchOnMobile says that the default behavior is to zoom the entire window but this isnt happening with enablePinchOnMobile set to false. For some reason, it seems that zooming is somehow completely disabled.

The reason Im playing with this variable is enablePinchOnMobile zooming seems to be completely broken (PDF.js 2.9 + v9.0 of library) but thats a whole other issue. Im looking to get basic zooming working as quick as I can.

@stephanrauh
Copy link
Owner

Which operating system are you using? I just tried with OSX, and it seems to be OK.

@stephanrauh stephanrauh self-assigned this Sep 8, 2021
@adambeer
Copy link
Author

adambeer commented Sep 8, 2021

This is on iOS. I tried directly on chrome and a react-native webview which I guess is iOS webkit.

@stephanrauh
Copy link
Owner

THX!

@stephanrauh
Copy link
Owner

Oops. I've managed to reproduce the bug on my iPad. I didn't expect that!

@stephanrauh stephanrauh added Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. Version 11 Scheduled for version 11 labels Sep 17, 2021
@stephanrauh
Copy link
Owner

Here's the culprit: mozilla/pdf.js#12212

BTW, zooming isn't entirely disabled. You just have to pull down the page with on finger before starting to pinch.

stephanrauh added a commit to stephanrauh/pdf.js that referenced this issue Sep 19, 2021
stephanrauh added a commit to stephanrauh/pdf.js that referenced this issue Sep 19, 2021
@stephanrauh
Copy link
Owner

The bugfix has landed with version 10.0.0.

@stephanrauh stephanrauh added Solved and removed Version 11 Scheduled for version 11 labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. Solved
Projects
None yet
Development

No branches or pull requests

2 participants