Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve performance of build_style method #5

Merged
merged 1 commit into from
Sep 29, 2024
Merged

perf: Improve performance of build_style method #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions lib/phlex/variants.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,19 @@ def build_style(**variants)

# @api private
def build_variants_style(variants)
self::STYLE_DEFAULTS.merge(variants.compact).map do |variant, option|
value = self::STYLE_VARIANTS.dig(variant, option)
variants = variants.compact
variants = self::STYLE_DEFAULTS.merge(variants) unless self::STYLE_DEFAULTS.empty?

if value.nil?
raise VariantNotFoundError, "Variant `#{variant}: #{option.inspect}` doesn't exist"
variants.map do |variant, option|
options = self::STYLE_VARIANTS[variant]

if options
value = options[option]

next value if value
end

value
raise VariantNotFoundError, "Variant `#{variant}: #{option.inspect}` doesn't exist"
end
end
end
Expand Down