-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling through timeline is jumping when using Bulma #95
Comments
Thank you for your report. I think I will change the classname is-hidden because is too common name. I created a PR. I just added : .vertical-timeline--animate .vertical-timeline-element-icon.is-hidden,
.vertical-timeline--animate .vertical-timeline-element-content.is-hidden {
display: block !important;
} |
Thank you @stephane-monnot. I can confirm that does resolve my issue! Should I anticipate a change like this making it into this project's codebase in the future? |
I think we need to rename the class is-hidden to vertical-timeline-is-hidden. If I have time, I will publish a fix |
This issue stemmed from bug stephane-monnot#95 related to jumping scrolling in SPA's that use Bulma. This is implementing the suggested fix. Co-authored-by: Stéphane Monnot <[email protected]>
To start, I believe this is a different Bulma issue than the one highlighted in issue #56 (which doesn't seem to be a problem for me).
Issue
While scrolling through the timeline, when I get to the start of a new
VerticalTimelineElement
, it will force the page to scroll further to fully accommodate showing the nextVerticalTimelineElement
, making the scrolling jump. I believe my use of Bulma is interfering with the timeline since removing my Bulma import resolves the issue.I verified this issue occurs in both Firefox and Chrome.
Reproduce
npm install
npm run dev
dist/index.html
file@import "bulma";
inindex.scss
, then reload page, notice how it scrolls smoothlyExpected Behavior
I would like to be able to use Bulma, and have smooth scrolling when scrolling through my timeline.
Notes
I changed my installed version of Bulma from 0.9.1 down to 0.8.0 and then to 0.7.5 to see if that would resolve the issue, but no luck.
P.S., this is a really cool package, and it's been fun to use so far 👍
The text was updated successfully, but these errors were encountered: