Optimize cache hits (#16)

* Optimize cache hits
stepanenko3 · Mar 31, 2024 · cac3bda · cac3bda
1 parent 03ee8f1
commit cac3bda
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 10 deletions.
diff --git a/config/nova-settings.php b/config/nova-settings.php
@@ -8,4 +8,8 @@
     'types' => [
         \Stepanenko3\NovaSettings\Types\General::class,
     ],
+
+    'storage' => [],
+
+    'cache_lifetime' => 3600,
 ];
diff --git a/src/helpers.php b/src/helpers.php
@@ -1,6 +1,7 @@
 <?php
 
 use Illuminate\Support\Facades\Cache;
+use Illuminate\Support\Facades\Config;
 
 if (!function_exists('settings')) {
     function settings(
@@ -13,16 +14,27 @@ function settings(
             $env = config('app.env');
         }
 
-        $settings = Cache::remember(
-            key: 'settings.' . $section . '.' . $env,
-            ttl: config('cache.lifetime'),
-            callback: fn () => config('nova-settings.model')::query()
-                ->select('settings')
-                ->where('slug', $section)
-                ->where('env', $env)
-                ->first()
-                ->settings ?? [],
-        );
+        $configKey = 'nova-settings.storage.' . $section . '.' . $env;
+
+        if ($value = config($configKey)) {
+            $settings = json_decode($value, true);
+        } else {
+            $settings = Cache::remember(
+                key: 'settings.' . $section . '.' . $env,
+                ttl: config('nova-settings.cache_lifetime', 3600),
+                callback: fn () => config('nova-settings.model')::query()
+                    ->select('settings')
+                    ->where('slug', $section)
+                    ->where('env', $env)
+                    ->first()
+                    ->settings ?? [],
+            );
+
+            Config::set(
+                key: $configKey,
+                value: json_encode($settings),
+            );
+        }
 
         if ($key === null) {
             return $settings;