Merge pull request #480 from h0x0er/jatin/cleanup

chore: clean the code
step-security · Oct 26, 2024 · 556aae6 · 556aae6
2 parents 40401cf + 6c39b84
commit 556aae6
Show file tree

Hide file tree

Showing 6 changed files with 75 additions and 107 deletions.
diff --git a/dist/post/index.js b/dist/post/index.js
diff --git a/dist/post/index.js.map b/dist/post/index.js.map
diff --git a/dist/pre/index.js b/dist/pre/index.js
diff --git a/dist/pre/index.js.map b/dist/pre/index.js.map
diff --git a/src/arc-runner.test.ts b/src/arc-runner.test.ts
@@ -7,14 +7,3 @@ it("should correctly recognize arc based runner", async () => {
   let isArc: boolean = await isArcRunner();
   expect(isArc).toBe(true);
 });
-
-it("should write endpoint files", () => {
-  process.env["isTest"] = "1";
-
-  let allowed_endpoints = [
-    "github.com:443",
-    "*.google.com:443",
-    "youtube.com",
-  ].join(" ");
-  sendAllowedEndpoints(allowed_endpoints);
-});
diff --git a/src/arc-runner.ts b/src/arc-runner.ts
@@ -21,28 +21,14 @@ function isSecondaryPod(): boolean {
   return fs.existsSync(workDir);
 }
 
-function getRunnerTempDir(): string {
-  const isTest = process.env["isTest"];
-
-  if (isTest === "1") {
-    return "/tmp";
-  }
-  return process.env["RUNNER_TEMP"] || "/tmp";
-}
-
 export function sendAllowedEndpoints(endpoints: string): void {
   const allowedEndpoints = endpoints.split(" "); // endpoints are space separated
 
   for (const endpoint of allowedEndpoints) {
     if (endpoint) {
       let encodedEndpoint = Buffer.from(endpoint).toString("base64");
-
-      let fileName = path.join(
-        getRunnerTempDir(),
-        `step_policy_endpoint_${encodedEndpoint}`
-      );
-
-      echo(fileName);
+      let endpointPolicyStr = `step_policy_endpoint_${encodedEndpoint}`;
+      echo(endpointPolicyStr);
     }
   }
 
@@ -53,9 +39,7 @@ export function sendAllowedEndpoints(endpoints: string): void {
 
 function applyPolicy(count: number): void {
   let applyPolicyStr = `step_policy_apply_${count}`;
-  let fileName = path.join(getRunnerTempDir(), applyPolicyStr);
-
-  echo(fileName);
+  echo(applyPolicyStr);
 }
 
 function echo(content: string) {