Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Fix MGS Premium Package #3289

Merged
merged 1 commit into from
Sep 6, 2024
Merged

GameDB: Fix MGS Premium Package #3289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions data/resources/discdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67487,13 +67487,13 @@ PAPX-90044:
- size: 331662576
md5: "de973cbfc9516106adac69984041f7be"
SCPS-45317:
name: "Metal Gear Solid (Asia) (Disc 1)"
name: "Metal Gear Solid (Japan, Asia) (Disc 1) (Ichi) (Premium Package)"
trackData:
- tracks:
- size: 710005296
md5: "d3b48095ed5d2a81a51d2b8ccd2ef766"
SCPS-45318:
name: "Metal Gear Solid (Asia) (Disc 2)"
name: "Metal Gear Solid (Japan, Asia) (Disc 2) (Ni) (Premium Package)"
trackData:
- tracks:
- size: 735526848
Expand Down Expand Up @@ -67658,18 +67658,6 @@ SLUS-90062:
- tracks:
- size: 123924528
md5: "794c18d04a31d1e7c5b39bbe4d088afa"
SLPM-86111:
name: "Metal Gear Solid [Premium Package Sai Hakkou Kinen]"
trackData:
- tracks:
- size: 710005296
md5: "d3b48095ed5d2a81a51d2b8ccd2ef766"
- tracks:
- size: 735526848
md5: "7c43ca912cdbde3f0e23d90f2a799ffa"
- tracks:
- size: 225474480
md5: "c55b7888dee7b6c471d25a0000c4dc32"
SLPS-00008:
name: "Metal Jacket (Japan)"
trackData:
Expand Down
42 changes: 10 additions & 32 deletions data/resources/gamedb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99027,9 +99027,9 @@ PAPX-90044:
traits:
- ForcePGXPCPUMode
SCPS-45317:
name: "Metal Gear Solid (Asia) (Disc 1)"
name: "Metal Gear Solid (Japan, Asia) (Disc 1) (Ichi) (Premium Package)"
discSet:
name: "Metal Gear Solid (Asia)"
name: "Metal Gear Solid (Japan, Asia) (Premium Package)"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this one wasn't actually being detected before, because otherwise it's going to change memory card names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't think of that... 😓

But yeah, the disc set wasn't detected before (at least on my testings on Windows 10), instead both discs were added to the game list as 2 separate entries but with the same Metal Gear Solid [Premium Package Sai Hakkou Kinen] name:

image

Should I make a new PR and use that name as the disc set name to make it "backward compatible"?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, don't worry about it. It's not like it deletes old cards, users would just have to rename them.

serials:
- SCPS-45317
- SCPS-45318
Expand All @@ -99038,6 +99038,9 @@ SCPS-45317:
- DigitalController
traits:
- ForcePGXPCPUMode
codes:
- SCPS-45317
- SLPM-86111
metadata:
publisher: "Konami"
developer: "KCE Japan"
Expand All @@ -99053,9 +99056,9 @@ SCPS-45317:
multitap: false
linkCable: false
SCPS-45318:
name: "Metal Gear Solid (Asia) (Disc 2)"
name: "Metal Gear Solid (Japan, Asia) (Disc 2) (Ni) (Premium Package)"
discSet:
name: "Metal Gear Solid (Asia)"
name: "Metal Gear Solid (Japan, Asia) (Premium Package)"
serials:
- SCPS-45317
- SCPS-45318
Expand All @@ -99064,6 +99067,9 @@ SCPS-45318:
- DigitalController
traits:
- ForcePGXPCPUMode
codes:
- SCPS-45318
- SLPM-86112
metadata:
publisher: "Konami"
developer: "KCE Japan"
Expand Down Expand Up @@ -99714,34 +99720,6 @@ SLPM-87030:
vibration: true
multitap: false
linkCable: false
SLPM-86111:
name: "Metal Gear Solid [Premium Package Sai Hakkou Kinen]"
compatibility:
rating: NoIssues
versionTested: "0.1-905-g237f469"
controllers:
- AnalogController
- DigitalController
traits:
- ForcePGXPCPUMode
codes:
- SLPM-86111
- SLPM-86112
- SLPM-86113
metadata:
publisher: "Konami"
developer: "KCE Japan"
releaseDate: "1998-09-03"
genre: "Action / Adventure / Strategy / Shooter"
languages:
- Japanese
minPlayers: 1
maxPlayers: 1
minBlocks: 1
maxBlocks: 1
vibration: true
multitap: false
linkCable: false
SLPS-00008:
name: "Metal Jacket (Japan)"
controllers:
Expand Down
Loading