Qt: Fix deadlock in Game Properties -> Post-Processing

stenzek · Dec 15, 2024 · 5e21234 · 5e21234
1 parent 90e9634
commit 5e21234
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/duckstation-qt/postprocessingsettingswidget.cpp b/src/duckstation-qt/postprocessingsettingswidget.cpp
@@ -284,16 +284,17 @@ PostProcessingShaderConfigWidget::~PostProcessingShaderConfigWidget() = default;
 
 void PostProcessingShaderConfigWidget::updateConfigForOption(const PostProcessing::ShaderOption& option)
 {
-  const auto lock = Host::GetSettingsLock();
+  auto lock = Host::GetSettingsLock();
   SettingsInterface& si = m_widget->getSettingsInterfaceToUpdate();
   PostProcessing::Config::SetStageOption(si, m_section, m_stage_index, option);
+  lock.unlock();
   m_widget->commitSettingsUpdate();
 }
 
 void PostProcessingShaderConfigWidget::onResetDefaultsClicked()
 {
   {
-    const auto lock = Host::GetSettingsLock();
+    auto lock = Host::GetSettingsLock();
     SettingsInterface& si = m_widget->getSettingsInterfaceToUpdate();
     for (PostProcessing::ShaderOption& option : m_options)
     {
@@ -303,6 +304,7 @@ void PostProcessingShaderConfigWidget::onResetDefaultsClicked()
       option.value = option.default_value;
       PostProcessing::Config::UnsetStageOption(si, m_section, m_stage_index, option);
     }
+    lock.unlock();
     m_widget->commitSettingsUpdate();
   }