-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break, continue and loops' labels #175
Conversation
87cd89f
to
58df5b6
Compare
20677fe
to
9cb7c6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While template writers can do this now with the set
tag, I think this would be easier (and shorter) to use.
I'm not 100% sold on the location/syntax of the label, but I don't have any better ideas 🤷♂️ What are other people's thoughts?
Before I forget: This PR should document the changes in the |
Is it something we still want to have or it can be closed? |
Hey 👋 I'm Eve, the friendly bot watching over Stencil 🤖 Thanks a lot for your contribution! Seems like everything is in order 👍 You did a good job here! 🤝 Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on master, added support for multi-level forloop
access, and fixed a bug in the tokenizer because of #178. The fix for that last one is "okay-ish" 🤷
This PR adds
break
andcontinue
tags for loops. They can be labeled, like in Swift, or not.Labeled loops:
Also with labels it's now possible to access outer loop context from inner loop: