docs(v3-upgrade): add note about deprecating cssVarsShim
#950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tanner-reits
requested changes
Dec 14, 2022
Comment on lines
93
to
115
| variables](https://developer.mozilla.org/en-US/docs/Web/CSS/--*). For Stencil | ||
| v3.0.0 this field is renamed to `__deprecated__cssVarsShim`, and thus to retain | ||
| the previous behavior the new option can be set in your projects | ||
| `stencil.config.ts`: |
There was a problem hiding this comment.
Part of this sounds a little weird to me. I think we should just copy-paste the same sentence used for dynamicImportShim. I don't see why we need different wording for essentially the same thing 🤷♂️
rwaskiewicz
approved these changes
Dec 14, 2022
14 tasks
|
edit: wrong pr! haha |
This adds a note to the v3 upgrade guide about deprecating `extras.cssVarShim`.
alicewriteswrongs
force-pushed
the
ap/deprecate-cssvar-note
branch
from
1fa9219 to
50cc9b7
Compare
tanner-reits
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note to the v3 upgrade guide about deprecating
extras.cssVarShim.NOTE: this PR has #948 as its base.