fix(compiler): make style getter behavior consistent between default and native components

[christian-bromann]

What is the current behavior?

Currently our nightly build is broken due changes introduced in #5131 (see https://github.com/ionic-team/ionic-framework/actions/runs/7124408050). Investigating this issue was difficult as it happens to be random behavior. However I found that the static style property wasn't applied correctly in the failing cases which gave me a hint to the location of this fix.

What is the new behavior?

I made changes in the order of if statements in getSingleStyle and getMultipleModeStyle
and have recognised a file with similar implementation features: /src/compiler/transformers/component-native/native-static-style.ts. Afaik this is done if transformOpts.componentExport is set to customelement.

It turns out that after aligning the order of if statements in addSingleStyleGetter with how it is in getSingleStyle the component was rendered correctly in a consistent fashion.

Does this introduce a breaking change?

• Yes
• No

Testing

Added some tests but you can reproduce the issue by:

• create a stencil project npm init stencil
• change the stencil dependency to be nightly in package.json: "@stencil/core": "nightly"
• npm install
• add another output target:

   {
     type: 'dist-custom-elements',
     dir: 'components',
   },
  

• go in components/my-component.js and verify that MyComponentStyle is not defined

No to verify the fix pack the build of this branch and link it to that project. After rebuilding the component you should see a myComponentCss defined.

Other information

[github-actions]

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1323 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/mock-doc/serialize-node.ts	36
src/dev-server/server-process.ts	32
src/compiler/style/test/optimize-css.spec.ts	23
src/compiler/output-targets/dist-lazy/generate-lazy-module.ts	22
src/compiler/prerender/prerender-main.ts	22
src/testing/puppeteer/puppeteer-element.ts	22
src/runtime/client-hydrate.ts	20
src/screenshot/connector-base.ts	19
src/runtime/vdom/vdom-render.ts	18
src/compiler/config/test/validate-paths.spec.ts	16
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/compiler/transpile/transpile-module.ts	14
src/runtime/vdom/vdom-annotations.ts	14
src/sys/node/node-sys.ts	14
src/compiler/prerender/prerender-queue.ts	13
src/compiler/sys/in-memory-fs.ts	13
src/runtime/connected-callback.ts	13

Our most common errors

Typescript Error Code	Count
TS2345	399
TS2322	374
TS18048	286
TS18047	101
TS2722	37
TS2532	30
TS2531	23
TS2454	14
TS2352	13
TS2790	10
TS2769	8
TS2538	8
TS2416	6
TS2344	5
TS2493	3
TS2488	2
TS18046	2
TS2684	1
TS2430	1

Unused exports report

There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	269	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	115	Env
src/compiler/app-core/app-data.ts	117	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	61	satisfies
src/compiler/types/validate-primary-package-output-target.ts	61	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync

[rwaskiewicz]

GH won't allow me to comment on a line higher than this one - can we add a comment before this conditional starts (above the if statement) that the order of the conditional must match add-static-style.ts#getSingleStyle?

[alicewriteswrongs]

on this point, I was thinking it might make sense to circle back after the bugfix is out and factor out this logic into a helper function since it looks essentially the same in these two spots

[rwaskiewicz]

GH won't allow me to comment on a line higher than this one - can we add a comment before this conditional starts (above the if statement) that the order of the conditional must match add-static-style.ts#getSingleStyle?

[alicewriteswrongs]

I tried out the fix locally and it looks good!

[christian-bromann]

@rwaskiewicz added comments, can I go ahead and merge?

[christian-bromann]

Got a 👍 through our internal communication platform. Going ahead and merge.