Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up get_SingleCell, add genes argument, add tests #24

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

multimeric
Copy link
Collaborator

@multimeric multimeric commented Oct 27, 2022

  • Optimised the @imports to close dplyr::filter not imported #14.
  • Added the genes argument to get_SingleCellExperiment to close Enable gene selection in get_SingleCellExperiment() #17
  • Added test for the genes argument
  • Removed all_genes which was unused
  • Use the variable name sces to clarify that we have a list of SCEs
  • Used assayNames() = instead of directly setting the names attribute
  • Tidied up some pipes
  • Re-ran roxygen to fix namespace issues

@stemangiola stemangiola merged commit bc47e43 into master Oct 27, 2022
@stemangiola
Copy link
Owner

@multimeric for this (and other edits to the interface) could you please update README with example?

I'm doing this for scaled counts for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable gene selection in get_SingleCellExperiment() dplyr::filter not imported
2 participants