-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new missions that trigger surge pricing/limiter at high volume traffic #64
Conversation
8b62a00
to
c83cc14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just had a few questions/suggestions
@@ -45,6 +48,8 @@ let allMissions : Map<string, Mission> = | |||
("ComplexTopology", complexTopology) | |||
("LoadGeneration", loadGeneration) | |||
("LoadGenerationWithSpikes", loadGenerationWithSpikes) | |||
("LoadGenerationWithTxSetLimit", loadGenerationWithTxSetLimit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also want to add these new missions to the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, but that should be a seprate PR to a different repo, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, wanted to make sure you're aware that another change is needed elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll keep this in mind while it's blocked by the core PR release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heads up, we can update the CI now
c83cc14
to
a238d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the updates, this looks great to me! We'll merge this once we land the prerequisite changes in core.
1ce41ec
to
106badb
Compare
Core changes have been finally merged (stellar/stellar-core#3492), so this should be ready to be merged, PTAL |
These are introduced by Core PR stellar/stellar-core#3492
…traffic: - Regular load generation, but with limiting/surge pricing triggering - Protocol upgrade under load/limiting - this would be relevant for e.g. p20 upgrade to use generalized tx sets - Running the mixed image version network at 51% quorum and with load - this could have caught network forking of 19.3.0 release.
106badb
to
229190d
Compare
This is based on the capability to generate load and ignore low fee tx errors (stellar/stellar-core#3492)
I'm adding the following scenarios: