Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new missions that trigger surge pricing/limiter at high volume traffic #64

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Aug 4, 2022

This is based on the capability to generate load and ignore low fee tx errors (stellar/stellar-core#3492)

I'm adding the following scenarios:

  • Regular load generation, but with limiting/surge pricing triggering
  • Protocol upgrade under load/limiting - this would be relevant for e.g. p20 upgrade to use generalized tx sets
  • Running the mixed image version network at 51% quorum and with load - this could have caught network forking of 19.3.0 release.

@dmkozh dmkozh force-pushed the high_traffic_mission branch 2 times, most recently from 8b62a00 to c83cc14 Compare August 8, 2022 19:16
Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just had a few questions/suggestions

@@ -45,6 +48,8 @@ let allMissions : Map<string, Mission> =
("ComplexTopology", complexTopology)
("LoadGeneration", loadGeneration)
("LoadGenerationWithSpikes", loadGenerationWithSpikes)
("LoadGenerationWithTxSetLimit", loadGenerationWithTxSetLimit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also want to add these new missions to the CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but that should be a seprate PR to a different repo, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, wanted to make sure you're aware that another change is needed elsewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll keep this in mind while it's blocked by the core PR release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up, we can update the CI now

Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the updates, this looks great to me! We'll merge this once we land the prerequisite changes in core.

@dmkozh dmkozh force-pushed the high_traffic_mission branch from 1ce41ec to 106badb Compare October 3, 2022 20:35
@dmkozh
Copy link
Contributor Author

dmkozh commented Oct 3, 2022

thank you for the updates, this looks great to me! We'll merge this once we land the prerequisite changes in core.

Core changes have been finally merged (stellar/stellar-core#3492), so this should be ready to be merged, PTAL

dmkozh added 2 commits October 3, 2022 17:37
…traffic:

- Regular load generation, but with limiting/surge pricing triggering
- Protocol upgrade under load/limiting - this would be relevant for e.g. p20 upgrade to use generalized tx sets
- Running the mixed image version network at 51% quorum and with load - this could have caught network forking of 19.3.0 release.
@dmkozh dmkozh force-pushed the high_traffic_mission branch from 106badb to 229190d Compare October 3, 2022 21:37
@marta-lokhova marta-lokhova merged commit 5884ad7 into stellar:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants