Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual C++ - don't pass the release flag to cargo for debug builds #4560

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

MonsieurNicolas
Copy link
Contributor

This makes it consistent with the way C++ code is build.

Makes debug builds faster to build and easier to use in with debuggers.

this makes it consistent with the way C++ code is build. Makes debug builds faster to build and easier to use in with debuggers.
Copy link
Contributor

@anupsdf anupsdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to remove the release profile from the Debug configurations and only use them for release configurations.

@anupsdf anupsdf added this pull request to the merge queue Nov 26, 2024
Merged via the queue into stellar:master with commit 21ce88b Nov 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants