Handle soroban loadgen mode misconfig gracefully #4559
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
previously approved these changes
Nov 26, 2024
| @@ -348,6 +348,13 @@ LoadGenerator::start(GeneratedLoadConfig& cfg) | |||
| if (cfg.modeInvokes()) | |||
| { | |||
| auto const& sorobanLoadCfg = cfg.getSorobanConfig(); | |||
| if (!mCodeKey) | |||
There was a problem hiding this comment.
Nit: Remove mCodeKey assert below.
SirTyson
reviewed
Nov 26, 2024
| @@ -125,6 +125,36 @@ TEST_CASE("generate load with unique accounts", "[loadgen]") | |||
| 10 * Herder::EXP_LEDGER_TIMESPAN_SECONDS, false); | |||
| } | |||
| } | |||
| TEST_CASE("handle soroban loadgen mode misconfiguration gracefully", | |||
There was a problem hiding this comment.
Nit: This doesn't have to be it's own test, but could just be a SECTION in "generate soroban load"
ThomasBrady
force-pushed
the
handle-soroban-loadgen-mode-misconfig-graceful
branch
from
ad5ae5a
to
b3f3ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4473
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)