Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio/MSVC build fixes #4443

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Visual Studio/MSVC build fixes #4443

merged 1 commit into from
Aug 27, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Aug 27, 2024

Description

This solves a number of issue that have broken MSVC build:

  • VS project fixes
  • Duplicate object names
  • Some MSVC-exclusive compile errors
    • Notably, MSVC has reached the limit of the code branching in Config.cpp. I did a small fix, but probably we should adapt the map pattern to more parameters

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@dmkozh dmkozh marked this pull request as ready for review August 27, 2024 22:11
@dmkozh dmkozh enabled auto-merge August 27, 2024 22:41
@dmkozh dmkozh added this pull request to the merge queue Aug 27, 2024
Merged via the queue into stellar:master with commit 052c40b Aug 27, 2024
14 checks passed
@dmkozh dmkozh deleted the vs_build_fix branch August 27, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisuresh sisuresh sisuresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmkozh @sisuresh