generalize support for multiple soroban hosts #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
generalize-multiple-soroban-hosts
branch
from
6fb11b8 to
3fd605a
Compare
graydon
force-pushed
the
generalize-multiple-soroban-hosts
branch
from
3fd605a to
4999ad9
Compare
dmkozh
reviewed
Aug 22, 2024
Closed
6 tasks
sisuresh
reviewed
Aug 22, 2024
dmkozh
previously approved these changes
Aug 22, 2024
graydon
force-pushed
the
generalize-multiple-soroban-hosts
branch
from
e879f70 to
d55f863
Compare
anupsdf
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to support more than just the two "curr" and "prev" soroban hosts, to allow us to decide case-by-case when we want to retire a soroban host version (when we find that a subsequent version can do faithful replay) and when we want to keep one around in perpetuity (when the differences between protocols are so great that it's not worth the cost).
Along the way this generalization seems to simplify the code.