Harden survey script to various failures #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
approved these changes
Aug 1, 2024
Closes stellar#4404 This change makes a few improvements to the survey script to enable it to better handle errors encountered during execution. Specifically, it: * Adds a periodic ping to the `/info` endpoint to keep any SSH tunnels the script may be running through alive. * Adds a flag `--startPhase` to allow the script to be attached to an already running survey. This ensures that if the script crashes it can pick up where it left off. * Additionally, the script now clears stellar-core's survey results cache when resuming gathering survey results. * Catches errors in `write_graph_stats` and logs them rather than crashing. * Writes out the graphml file as soon as the graph is complete so that any unhandled errors don't throw away the graph. * Batches survey requests into smaller batches. * Renames `--collect-duration` to `--collectDuration` for consistency with the other long option names.
marta-lokhova
force-pushed
the
survey-script-hardening
branch
from
f9327c4 to
b4b1e03
Compare
bboston7
added a commit
to bboston7/stellar-core
that referenced
this pull request
Dec 20, 2024
This change updates the survey script documentation to reflect changes from stellar#4407. It also fixes a link to the admin guide.
bboston7
added a commit
to bboston7/stellar-core
that referenced
this pull request
Dec 21, 2024
This change updates the survey script documentation to reflect changes from stellar#4407. It also fixes a link to the admin guide.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2025
This change updates the survey script documentation to reflect changes from #4407. It also fixes a link to the admin guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4404
This change makes a few improvements to the survey script to enable it to better handle errors encountered during execution. Specifically, it:
/infoendpoint to keep any SSH tunnels the script may be running through alive.--startPhaseto allow the script to be attached to an already running survey. This ensures that if the script crashes it can pick up where it left off.write_graph_statsand logs them rather than crashing.--collect-durationto--collectDurationfor consistency with the other long option names.I tested these changes using the script's
simulatemode.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)