Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply time benchmarking #4402

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Apply time benchmarking #4402

merged 6 commits into from
Sep 18, 2024

Conversation

sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Jul 30, 2024

Description

Resolves #4391.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked too deeply into implementation, but looks good overall! (and seems already usable, would be interesting to see the results for our current configuration) Just left a few nit-picks/questions.

src/simulation/ApplyLoad.cpp Outdated Show resolved Hide resolved
src/simulation/ApplyLoad.h Outdated Show resolved Hide resolved
src/simulation/TxGenerator.h Outdated Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Outdated Show resolved Hide resolved
src/main/CommandLine.cpp Outdated Show resolved Hide resolved
@sisuresh sisuresh force-pushed the bench branch 3 times, most recently from 63f0d25 to 84d55fe Compare August 2, 2024 23:01
@sisuresh sisuresh force-pushed the bench branch 4 times, most recently from 681343f to c2ac746 Compare August 13, 2024 00:05
@sisuresh sisuresh marked this pull request as ready for review August 13, 2024 00:11
@sisuresh sisuresh requested a review from bboston7 August 14, 2024 23:41
src/main/CommandLine.cpp Outdated Show resolved Hide resolved
src/simulation/ApplyLoad.h Show resolved Hide resolved
src/simulation/ApplyLoad.h Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Outdated Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Outdated Show resolved Hide resolved
src/herder/HerderImpl.cpp Outdated Show resolved Hide resolved
src/simulation/TxGenerator.h Outdated Show resolved Hide resolved
src/simulation/TxGenerator.h Show resolved Hide resolved
src/simulation/TxGenerator.cpp Outdated Show resolved Hide resolved
src/simulation/TxGenerator.cpp Outdated Show resolved Hide resolved
src/main/CommandLine.cpp Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Outdated Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Outdated Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Outdated Show resolved Hide resolved
dmkozh
dmkozh previously approved these changes Sep 16, 2024
Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if we want to include this in p22 build. On one hand, this is not risky from the protocol standpoint, on the other hand we're modifying loadgen and that has a bit of risk for supercluster tests. I think we still have a bit of time before cutting the release, so we should have a run with just these changes. WDYT?

src/main/CommandLine.cpp Show resolved Hide resolved
src/simulation/ApplyLoad.cpp Show resolved Hide resolved
@dmkozh
Copy link
Contributor

dmkozh commented Sep 16, 2024

Actually there are some test failures, so we need to address these first.

@sisuresh
Copy link
Contributor Author

LGTM, but I'm not sure if we want to include this in p22 build. On one hand, this is not risky from the protocol standpoint, on the other hand we're modifying loadgen and that has a bit of risk for supercluster tests. I think we still have a bit of time before cutting the release, so we should have a run with just these changes. WDYT?

Yeah that's a good point. The good thing is that if this change did break loadgen, we'd find out pretty quickly in SSC, so I think it's fine to merge. Worst case we'll just have to revert it.

@sisuresh sisuresh added this pull request to the merge queue Sep 17, 2024
Merged via the queue into stellar:master with commit 7712e4a Sep 18, 2024
14 checks passed
@sisuresh sisuresh deleted the bench branch September 18, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark for measuring ledger apply time
3 participants