Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup outdated surge pricing logic. #4383

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Jul 11, 2024

Description

Cleanup outdated surge pricing logic.

  • Remove tx stacks in surge pricing queue as we have only a single tx/account
  • Remove lazy fee computation for legacy tx sets (not sure it was necessary before)
  • Remove tests covering surge pricing logic for old protocols. Replay doesn't need to emulate surge pricing.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@dmkozh dmkozh force-pushed the surge_pricing_cleanup branch 6 times, most recently from 9062d6e to 79501f3 Compare July 13, 2024 00:56
src/herder/TxSetUtils.h Show resolved Hide resolved
src/herder/SurgePricingUtils.h Outdated Show resolved Hide resolved
src/herder/TxQueueLimiter.h Outdated Show resolved Hide resolved
src/herder/TxQueueLimiter.h Show resolved Hide resolved
src/herder/TxSetUtils.cpp Show resolved Hide resolved
src/herder/SurgePricingUtils.cpp Outdated Show resolved Hide resolved
src/herder/TxQueueLimiter.h Outdated Show resolved Hide resolved
src/herder/TxQueueLimiter.h Outdated Show resolved Hide resolved
src/herder/test/TransactionQueueTests.cpp Show resolved Hide resolved
src/herder/test/HerderTests.cpp Outdated Show resolved Hide resolved
src/herder/TxSetFrame.cpp Show resolved Hide resolved
src/herder/TxSetFrame.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates! Could you please squash commits?

- Remove tx stacks in surge pricing queue as we have only a single tx/account
- Remove lazy fee computation for legacy tx sets (not sure it was necessary before)
- Remove tests covering surge pricing logic for old protocols. Replay doesn't need to emulate surge pricing.
@dmkozh dmkozh force-pushed the surge_pricing_cleanup branch from 4beaec1 to de041a1 Compare July 23, 2024 23:42
@dmkozh
Copy link
Contributor Author

dmkozh commented Jul 23, 2024

LGTM, thanks for the updates! Could you please squash commits?

Done

@marta-lokhova marta-lokhova enabled auto-merge July 23, 2024 23:47
@marta-lokhova marta-lokhova added this pull request to the merge queue Jul 24, 2024
Merged via the queue into stellar:master with commit a6d6f08 Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants