Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env to 20.0.2 #4301

Merged
merged 4 commits into from
May 6, 2024
Merged

Update env to 20.0.2 #4301

merged 4 commits into from
May 6, 2024

Conversation

jayz22
Copy link
Contributor

@jayz22 jayz22 commented May 1, 2024

Description

  • Bump curr env version to 20.0.2
  • Remove temporary cost type size fix introduced in 6c5d40f

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@jayz22 jayz22 requested a review from sisuresh May 1, 2024 20:31
@sisuresh
Copy link
Contributor

sisuresh commented May 1, 2024

Should we wait until env is released? While core does use the git rev, the version endpoint reports the version number as well. Example -

src/stellar-core version
v21.0.0rc1-69-g07d3362eb
rust version: rustc 1.74.1 (a28077b28 2023-12-04)
soroban-env-host:
    curr:
        package version: 21.0.0
        git version: cd534ed18dc44368b26e0c5089756cd1bcde0bc1
        ledger protocol version: 21
        pre-release version: 0
        rs-stellar-xdr:
            package version: 21.0.0
            git version: 290d32a9a1b72a55406ecf1f67d8ec8839584659
            base XDR git version: 2ba4049554bb0564950e6d9213e01a60fc190f54
    prev:
        package version: 20.3.0
        git version: 93120b6b32cd910fcc224cbf6aec1333f771a8bc
        ledger protocol version: 20
        pre-release version: 0
        rs-stellar-xdr:
            package version: 20.1.0
            git version: 2e0f7f7d42fcd6c3c42eb0d65570fba9f5193d7e
            base XDR git version: cdc339f5e74a75e8e558fd1a853397da71f1659a

@jayz22
Copy link
Contributor Author

jayz22 commented May 1, 2024

Should we wait until env is released? While core does use the git rev, the version endpoint reports the version number as well. Example -

src/stellar-core version
v21.0.0rc1-69-g07d3362eb
rust version: rustc 1.74.1 (a28077b28 2023-12-04)
soroban-env-host:
    curr:
        package version: 21.0.0
        git version: cd534ed18dc44368b26e0c5089756cd1bcde0bc1
        ledger protocol version: 21
        pre-release version: 0
        rs-stellar-xdr:
            package version: 21.0.0
            git version: 290d32a9a1b72a55406ecf1f67d8ec8839584659
            base XDR git version: 2ba4049554bb0564950e6d9213e01a60fc190f54
    prev:
        package version: 20.3.0
        git version: 93120b6b32cd910fcc224cbf6aec1333f771a8bc
        ledger protocol version: 20
        pre-release version: 0
        rs-stellar-xdr:
            package version: 20.1.0
            git version: 2e0f7f7d42fcd6c3c42eb0d65570fba9f5193d7e
            base XDR git version: cdc339f5e74a75e8e558fd1a853397da71f1659a

yeah good point. Perhaps it's better to wait for the actual version then.

@jayz22 jayz22 changed the title Update env to 20.0.1 Update env to 20.0.2 May 6, 2024
@dmkozh
Copy link
Contributor

dmkozh commented May 6, 2024

r+ 367d2c3

@latobarita latobarita merged commit 08d89bb into stellar:master May 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants