Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the resource fee meta #4255

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Mar 20, 2024

Description

Populate the fields introduced in stellar/stellar-xdr#175

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@dmkozh dmkozh force-pushed the resource_fee_meta branch 3 times, most recently from de0f389 to ffa7b8f Compare March 26, 2024 20:29
@dmkozh dmkozh marked this pull request as ready for review March 26, 2024 21:42
@sydneynotthecity
Copy link

@dmkozh are there future plans to also emit the write_fee? Or is there a way for us to derive the write_fee based on the newly included fee fields?

@dmkozh
Copy link
Contributor Author

dmkozh commented Mar 27, 2024

@dmkozh are there future plans to also emit the write_fee? Or is there a way for us to derive the write_fee based on the newly included fee fields?

It's been added in stellar/stellar-xdr#174.

@sisuresh
Copy link
Contributor

r+ f32c6ea

@latobarita latobarita merged commit 737ff73 into stellar:master Mar 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants