Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update soroban settings files and utils #4197

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

sisuresh
Copy link
Contributor

Description

  1. Add a testnet_settings.json file for testnet copied from pubnet_phase.json.
  2. Update testnet to use bucket_list_target_size_bytes=200000000 and write_fee1_kb_bucket_list_low=-12034.
  3. Update utils to allow for lower target sizes.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from dmkozh February 16, 2024 00:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also update the target BL size for pubnet (to 13000000000)? We'll need to double-check it, but it seems unlikely that BL size would change significantly before phase 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good catch. Fixed

@dmkozh
Copy link
Contributor

dmkozh commented Feb 16, 2024

r+ 8b1d8f1

@latobarita latobarita merged commit a406d4b into stellar:master Feb 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants