Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soroban flooding and tx set construction followup #3780

Merged
merged 20 commits into from
Jun 15, 2023
Merged

Soroban flooding and tx set construction followup #3780

merged 20 commits into from
Jun 15, 2023

Conversation

marta-lokhova
Copy link
Contributor

@marta-lokhova marta-lokhova commented Jun 14, 2023 •
edited
Loading

Various improvements to #3766. Most significant additions are:

  • Incorporate Soroban tx limit into flooding, tx limiting, and tx set construction (now that Add max tx count for Soroban network settings #3767 is merged)
  • Tx set validity checks: ensure we do not go over Soroban ledger limits, enforce 1 tx per source account (caveat is that we can't enable this on all tests yet, see comment)
  • Tests for tx set validity and limits
  • Cleanups, Soroban-specific flooding configs as opposed to re-using classic, incorporating Soroban tx limit into pull mode

@marta-lokhova marta-lokhova force-pushed the soroban_flooding_followup branch from 7fdd01a to 00bcdcb Compare June 14, 2023 17:30
@marta-lokhova
Add a test for multiple txs per source account, but introduce a speci…
cb614ea 
…al config to toggle the check; Otherwise, the whole test suite is impacted by the check
@marta-lokhova
macro police
b6b95d5
@marta-lokhova
Small test improvement
c836e21
@marta-lokhova marta-lokhova force-pushed the soroban_flooding_followup branch from dad2aa7 to c836e21 Compare June 14, 2023 18:33
dmkozh
dmkozh reviewed Jun 14, 2023
View reviewed changes
src/herder/SurgePricingUtils.cpp Outdated Show resolved Hide resolved
src/transactions/TransactionFrame.cpp Outdated Show resolved Hide resolved
src/herder/TransactionQueue.cpp Outdated Show resolved Hide resolved
src/herder/TxSetFrame.cpp Outdated Show resolved Hide resolved
src/herder/test/TestTxSetUtils.cpp Outdated Show resolved Hide resolved
src/herder/test/TxSetTests.cpp Outdated Show resolved Hide resolved
@marta-lokhova marta-lokhova force-pushed the soroban_flooding_followup branch from cf31b0a to ded2ce9 Compare June 14, 2023 23:50
@dmkozh
Copy link
Contributor

dmkozh commented Jun 15, 2023

r+ d185bd7

@latobarita latobarita merged commit f7394f1 into stellar:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marta-lokhova @dmkozh @latobarita