Fixup xdr hash script #3663
Merged
Fixup xdr hash script #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I found myself replacing |
sed and perl are mentioned in docs and used in scripts
sed is not portable - some platforms (OSX) do not behave like others
MonsieurNicolas
force-pushed
the
fixupXDRHash
branch
from
8d928a2 to
b49c6bd
Compare
|
r+ b49c6bd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the script that we use to compute xdr hashes is not reliable on some platforms (MacOSX) because of a non standard interface.
This switches to using perl (that we already depend on) that is much more stable.