Improve asan and diagnostics in CI #3629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rerun tests under a debugger as to catch the backtrace and output it in the logs.
This allows to diagnose issues caught by asan much quicker as it reduces the need to repro issues locally.
We can probably improve this further in the future to give better context outside of crashes (by passing
-b
option when running tests for example).Example below (output from
make check
under the same conditions thanci-build.sh
):