Pass the source account into the host and allow calling into the token wrapper host functions #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
changed the title
dmkozh
reviewed
Sep 27, 2022
| // verify contract code is correct | ||
| LedgerTxn ltx2(app.getLedgerTxnRoot()); | ||
| auto ltxe2 = loadContractData(ltx2, contractID, wasmKey); | ||
| REQUIRE((bool)ltxe2 == expectEntry); |
There was a problem hiding this comment.
nit: Please use static_cast - c-style casts should normally be avoided in c++.
| { | ||
| case HostFunction::HOST_FN_CREATE_CONTRACT_WITH_ED25519: | ||
| { | ||
| // uint256 salt = sha256("salt"); |
|
Marked as draft so we can get #3547 in as well. |
sisuresh
changed the title
graydon
reviewed
Sep 28, 2022
| host.invoke_function(hf, args)?; | ||
| } | ||
| HostFunction::CreateContract => { |
There was a problem hiding this comment.
Not important to do now but the only thing differing between these arms is what gets logged, and these enum values all have debug representations -- you can just print that into the log and use a single branch here, don't need to switch on the value.
There was a problem hiding this comment.
Good point. Fixed.
graydon
approved these changes
Sep 28, 2022
|
r+ 060a6bb |
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3546 and #3547.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)