Rust log to core #3432
Merged
Rust log to core #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
graydon
force-pushed
the
rust-log-to-core
branch
3 times, most recently
from
062be39 to
754f1cf
Compare
jonjove
reviewed
Jun 2, 2022
| { | ||
| log::set_logger(&LOGGER)?; | ||
| } | ||
| log::set_max_level(maxFilter); |
There was a problem hiding this comment.
I think this should also be getting called when Logging::setLogLevel is called, right?
There was a problem hiding this comment.
Yes, any time you change anything in the logging system it gets "deinitialized" and "reinitialized" in the C++ Logging.cpp / spdlog side. That's why there's the HAVE_INITIALIZED bool in the Rust side, to prevent multiple-initialization.
|
There's one open question that only impacts the rust side, not the C++ side. So I'm going to merge. |
|
r+ 51009b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the back of #3428 by connecting the Rust standard
logcrate API to the stellar-core logging subsystem, allowing us to fairly normally writeinfo!(...)calls in Rust and have them come out ofspdlog.Along the way it adds a little bit of additional plumbing in the bridge module and renames C++ bridging-related files yet again (hopefully for the last time) to match our CamelCase naming convention on C++ files.