Skip to content

Commit

Permalink
Fix typo that inverts condition of test
Browse files Browse the repository at this point in the history
  • Loading branch information
@graydon
graydon committed Feb 21, 2024
1 parent a8c5ad4 commit bd01b44
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/herder/Upgrades.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ Upgrades::isValid(UpgradeType const& upgrade, LedgerUpgradeType& upgradeType,
res = res && isValidForNomination(lupgrade, ltx, header);
}

if (res && lupgrade.type() != LEDGER_UPGRADE_VERSION)
if (res && lupgrade.type() == LEDGER_UPGRADE_VERSION)
{
// We enforce here that _voting_ for any soroban-era protocol upgrade
// only happens from nodes that have two copies of soroban compiled-in
Expand Down

5 comments on commit bd01b44

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from dmkozh
at bd01b44

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging stellar/stellar-core/bug-4193-restrict-prev-test-to-voting = bd01b44 into auto

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stellar/stellar-core/bug-4193-restrict-prev-test-to-voting = bd01b44 merged ok, testing candidate = e4992c7

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass:
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21840177186
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839549715
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839549598
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839549502
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839549387
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839549248
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839549133
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839548999
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839548872
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839548732
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839548607
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839548494
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839548300
success: https://github.com/stellar/stellar-core/actions/runs/7996647889/job/21839547954

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = e4992c7

Please sign in to comment.