Feat/os keychain followup

[elizabethengelman]

What

This PR is based on #1703 and adds some additional compatibility with the secure store like keys rm and keys add.

• keys rm
• keys add
• manual test on Mac OS
  • add the key: cargo run keys add --secure-store --entry-name alice alice
  • make sure we can get the address from the new key: cargo run keys address alice
  • make sure we can sign & send with the new key:

      stello contract deploy --wasm target/test-wasms/hello_world.wasm  --build-only --network testnet --source alice | \
      stello tx simulate --network testnet --source alice | \
      stello tx sign --network testnet --sign-with-key alice | \
      stello tx send --network testnet
  

  • remove the key: stello keys rm alice
  • make sure it is no longer in the list or the keychain
• manual test on Linux
  • add the key: cargo run keys add --secure-store --entry-name alice alice
  • make sure we can get the address from the new key: cargo run keys address alice
  • make sure we can sign & send with the new key:

      stello contract deploy --wasm target/test-wasms/hello_world.wasm  --build-only --network testnet --source alice | \
      stello tx simulate --network testnet --source alice | \
      stello tx sign --network testnet --sign-with-key alice | \
      stello tx send --network testnet
  

  • remove the key: stello keys rm alice
  • make sure it is no longer in the list or the keychain
• manual test on Windows
  • add the key: cargo run keys add --secure-store --entry-name alice alice
  • make sure we can get the address from the new key: cargo run keys address alice
  • make sure we can sign & send with the new key:

      stello contract deploy --wasm target/test-wasms/hello_world.wasm  --build-only --network testnet --source alice | \
      stello tx simulate --network testnet --source alice | \
      stello tx sign --network testnet --sign-with-key alice | \
      stello tx send --network testnet
  

  • remove the key: stello keys rm alice
  • make sure it is no longer in the list or the keychain

Why

I wanted to keep #1703 from getting too big so it was easier to review.

Known limitations

[TODO or N/A]

[willemneal]

Suggested change

	Err(e) if e.to_string() == keyring::Error::NoEntry.to_string() => {
	Err(keyring::Error::NoEntry) => {

Is e equal to the the error? Does this work?

[elizabethengelman]

Yeah, this line is a bit weird, thanks for reminding me! The thing I was running into is that e an error wrapped in custom errors twice, if that makes sense => locator::Error -> signer::keyring::Error -> keyring::Error. So, matching directly on keyring::Error::NoEntry wasn't working.

I just pushed up an update so we're not comparing the error strings. Lmk what you think!