Feat/rpc tests #1202
Merged
Feat/rpc tests #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked. Needs on help on this failure: https://github.com/stellar/soroban-tools/actions/runs/7921583339/job/21627229312?pr=1202 and also which quickstart to point to |
willemneal
force-pushed
the
feat/rpc_tests
branch
2 times, most recently
from
e465789 to
82a317e
Compare
|
Still blocked. Tests are flaky. This blocks #1106 |
willemneal
force-pushed
the
feat/rpc_tests
branch
from
82a317e to
8cad000
Compare
|
I was able to fix the rpc tests with some sleeps (which suggests a concurrency issue), but it seems that I shouldn't use async traits in one of the msrv tests because it's a recent addition to rust. Is this an issue? I could probably use the crate, but last time I tried (a year ago) I ran into some issues. |
willemneal
force-pushed
the
feat/rpc_tests
branch
3 times, most recently
from
59ece7d to
f390d56
Compare
willemneal
force-pushed
the
feat/rpc_tests
branch
from
c586dd4 to
9b77f3a
Compare
The changes in this commit update the dependencies and refactor the test code to improve readability and maintainability. chore: remove unused code and options from test script
willemneal
force-pushed
the
feat/rpc_tests
branch
from
9b77f3a to
33c4cbe
Compare
leighmcculloch
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds NetworkRunnable trait so that commands that need the RPC can have a common run function.
Adds to the bindings action to test RPC.
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]