Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deployer functions that return the deployed contract id. #1086

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Sep 15, 2023

What

Implement deployer functions that return the deployed contract id.

Why

These have the respective host fns now and thus can be implemented.

Close #730

Known limitations

N/A

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for plugging this gap. Suggestions inline for documentation.

soroban-sdk/src/deploy.rs Outdated Show resolved Hide resolved
soroban-sdk/src/deploy.rs Outdated Show resolved Hide resolved
@leighmcculloch leighmcculloch added this pull request to the merge queue Sep 15, 2023
Merged via the queue into stellar:main with commit c48d4f4 Sep 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for getting contract IDs that would be assigned to deployments
2 participants