Rename logger to logs #1005
Merged
Rename logger to logs #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename env.logger() to env.logs().
Why
The logger function is inconsistently named compared to the other functions for accessing resources. E.g.
events,storage,ledger. I keep looking for logs and having to remember it is logger. The type is used not just for the act of logging, but also the act accessing logs in tests.Note that the deploy functionality is under
deployer, but it's not one that as easily renamed todeployordeploys.The rename is done backwards compatible with a deprecated notice, so folks will get a meaningful warning message and do not need to go hunting for the new function.