Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing to use latest dev rpc/horizon with protocol 22 #632

Merged
merged 10 commits into from
Oct 15, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 10, 2024

What

Update testing to use latest dev rpc/horizon with protocol 22.

Tracking protocol22 for rpc.

Tracking protocol-22 branch for horizon and friendbot.

Why

For the @stellar/devx team to be able to use something to test with.

Merging

This change is not intended for merging because it references versions of rpc, horizon, and friendbot that have not yet been released.

@willemneal
Copy link
Member

I was able to build this locally and update the protocol version to 22, but I get the following when trying to do an install:

❌ error: transaction simulation failed: cannot create budget from network configuration

@leighmcculloch
Copy link
Member Author

leighmcculloch commented Oct 10, 2024

The arm64 packages aren't finished yet, but you can run the amd64, and it'll emulate on arm64:

docker run \
    --platform linux/amd64 \
    -p 8000:8000 \
    stellar/quickstart:pr632-v445-testing-amd64 \
    --protocol-version 22 \
    --local

@leighmcculloch
Copy link
Member Author

I was able to build this locally and update the protocol version to 22, but I get the following when trying to do an install:

❌ error: transaction simulation failed: cannot create budget from network configuration

I see the same. Here's the full output:

❯ stellar contract install --wasm target/wasm32-unknown-unknown/release/test_add_u64.wasm --network local --source me
ℹ️  Simulating install transaction…
❌ error: transaction simulation failed: cannot create budget from network configuration

Caused by:
    HostError: Error(Budget, InternalError)
    DebugInfo not available

Here's the output of the rpc logs:

time="2024-10-10T13:52:10.453Z" level=info msg="starting JSONRPC request" json_req=18 method=simulateTransaction pid=488 req=36 subsys=jsonrpc
time="2024-10-10T13:52:10.454Z" level=info msg="finished JSONRPC request" duration="907.584µs" json_req=36 pid=488 req=36 status=error subsys=jsonrpc

Makefile Outdated Show resolved Hide resolved
@willemneal
Copy link
Member

You were pointing at main instead of the protocol22 branch. I am now getting an XDR length error. However, the transactions do seem to succeed.

Co-authored-by: Willem Wyndham <[email protected]>
Makefile Outdated Show resolved Hide resolved
@willemneal
Copy link
Member

@leighmcculloch I updated the commits again to the RPC that updated the rust deps. I then fixed some bugs I found in the client and updated that PR and the CLI to use it. Everything seems to be working locally! So once we get the images rebuilt we should be able to test it in CI!

Makefile Outdated Show resolved Hide resolved
@leighmcculloch
Copy link
Member Author

docker run \
    -p 8000:8000 \
    stellar/quickstart:pr632-v449-testing \
    --protocol-version 22 \
    --local

@leighmcculloch leighmcculloch marked this pull request as ready for review October 15, 2024 22:45
@leighmcculloch leighmcculloch enabled auto-merge (squash) October 15, 2024 23:20
@leighmcculloch leighmcculloch merged commit 1250b40 into master Oct 15, 2024
177 checks passed
@leighmcculloch leighmcculloch deleted the rpc-horizon-friendbot-22 branch October 15, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants