Add option to sign transaction hash with Ledger device (#838)

stellar · Apr 30, 2024 · 7f26d29 · 7f26d29
1 parent ed2094d
commit 7f26d29
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/src/actions/transactionSigner.js b/src/actions/transactionSigner.js
@@ -50,7 +50,7 @@ export const ALBEDO_WALLET_SIGN_START = "ALBEDO_WALLET_SIGN_START";
 export const ALBEDO_WALLET_SIGN_SUCCESS = "ALBEDO_WALLET_SIGN_SUCCESS";
 export const ALBEDO_WALLET_SIGN_ERROR = "ALBEDO_WALLET_SIGN_ERROR";
 
-export function signWithLedger(txXDR, bipPath, networkPassphrase) {
+export function signWithLedger(txXDR, bipPath, networkPassphrase, isHash) {
   return (dispatch) => {
     dispatch({ type: LEDGER_WALLET_SIGN_START });
 
@@ -77,9 +77,15 @@ export function signWithLedger(txXDR, bipPath, networkPassphrase) {
       ledgerApi
         .getPublicKey(bipPath)
         .then((result) => (publicKey = result.publicKey))
-        .then(() =>
-          ledgerApi.signTransaction(bipPath, transaction.signatureBase()),
-        )
+        .then(() => {
+          if (isHash) {
+            return ledgerApi.signHash(bipPath, transaction.hash());
+          }
+          return ledgerApi.signTransaction(
+            bipPath,
+            transaction.signatureBase(),
+          );
+        })
         .then((result) => {
           let { signature } = result;
           let keyPair = Keypair.fromPublicKey(publicKey);

diff --git a/src/views/TransactionSigner.tsx b/src/views/TransactionSigner.tsx
@@ -403,6 +403,17 @@ export const TransactionSigner = () => {
                     >
                       Sign with Ledger
                     </button>
+                    <button
+                      className="s-button"
+                      data-testid="transaction-signer-ledger-sign-button"
+                      onClick={() => {
+                        dispatch(
+                          signWithLedger(xdr, bipPath, networkPassphrase, true),
+                        );
+                      }}
+                    >
+                      Sign hash with Ledger
+                    </button>
                     <button
                       className="s-button"
                       data-testid="transaction-signer-trezor-sign-button"